refactor: member relink and member_team initiation#426
Merged
BlackBean99 merged 1 commit intodevelopfrom Mar 18, 2026
Merged
Conversation
Contributor
|
Caution Review failedPull request was closed or merged during review Walkthrough회원 로그인 및 가입 흐름에 회원 팀 초기화를 추가하고, 고아 상태의 OAuth 회원에 대한 복구 로직을 도입하며, 삭제된 회원을 제외하도록 회원 선택 로직을 정제하고, OAuth 제공자 재연결 기능을 추가합니다. Changes
Sequence DiagramsequenceDiagram
participant Client
participant AuthService as Auth Service
participant MemberLoginSvc as Member Login Service
participant MemberOAuthSvc as Member OAuth Service
participant MemberTeamSvc as Member Team Service
participant DB as Database
Client->>AuthService: Login with OAuth Credentials
AuthService->>MemberLoginSvc: selectLoginCandidate()
MemberLoginSvc->>DB: Query member by email (exclude deletedAt != null)
DB-->>MemberLoginSvc: Member or null
alt Member not found
MemberLoginSvc->>MemberLoginSvc: recoverOrCreateMemberForOrphanedOAuth()
MemberLoginSvc->>DB: Create or find member
DB-->>MemberLoginSvc: Member
MemberLoginSvc->>MemberOAuthSvc: relinkMemberOAuthProvider()
MemberOAuthSvc->>DB: Relink OAuth to member
DB-->>MemberOAuthSvc: Success
end
MemberLoginSvc->>MemberTeamSvc: ensureMemberTeamInitialized(memberId)
MemberTeamSvc->>DB: Check member's team assignment
DB-->>MemberTeamSvc: Team or none
alt No team assigned and default team configured
MemberTeamSvc->>DB: Create MemberTeam with default team
DB-->>MemberTeamSvc: Success
end
MemberTeamSvc-->>MemberLoginSvc: Initialization complete
MemberLoginSvc-->>AuthService: Login successful
AuthService-->>Client: Auth token
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the high-level summary generated by CodeRabbit.Configure the |
BlackBean99
added a commit
that referenced
this pull request
Mar 18, 2026
…aving (#428) * add response field (memberId, cohortId) (#391) * initiation of new member and new announcement (#393) * appleOAuth name resolution (#395) * whitelist email -> memberId parameter changing (#398) * whitelist email login (parameter email -> memberId) (#399) * whitelist email -> memberId parameter changing * whitelist email -> memberId parameter changing * refactor/#397 (#400) * whitelist email -> memberId parameter changing * whitelist email -> memberId parameter changing * whitelist email -> memberId parameter changing * whitelist email -> memberId parameter changing (#402) * member_roles auto align (#405) * re-sync member_roles after whitelist (#407) * filtered member overview by cohort (#412) * filtered member overview by cohort * after_party_invitees 보상로직 * AFTERPARTY_COMPENSATIONRESPONSE * feat: member overview true/false of latest cohort (#414) * feat: member overview true/false of latest cohort * feat: member overview true/false of latest cohort * feat: invitees invitation iniation (#417) * feat: part null safe (#420) * refactor : Session url open and Cohort value adding (#425) * refactor: member relink and member_team initiation (#426) * PENDING initiation (#427) * refactor: member relink and member_team initiation * refactor : PENDING refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tasks
ETC
Screenshot
Summary by CodeRabbit
릴리스 노트
새로운 기능
개선사항