Repository navigation
[GLB-210, GLB-239] fix(profile): 공백 닉네임 저장 막기와 직접 진입 화면의 뒤로가기 대체 경로 - #373
Merged
Merged
Conversation
- 저장값의 앞뒤 공백 처리 규칙은 기획 확정 전이라 바꾸지 않음
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
GLB-210
packages/shared/src/schemas/profile.ts)에value.trim().length > 0검사를 추가했습니다. 공백만 있으면 "닉네임을 입력해주세요."로 거부합니다.EditProfileBottomSheet.tsx)이 스키마 결과가 아니라nickname.length === 0을 직접 보고 있었습니다. 그래서!nickname?.trim()으로 바꿨습니다." 글로버 "는 지금처럼 통과합니다.GLB-239
apps/web/src/utils/navigation.ts에goBackOrFallback(router, fallbackHref)를 추가했습니다.window.history.length > 1이면router.back(), 아니면 기본 경로로 이동합니다.ErrorPageContent의 기존 뒤로가기와 같은 기준입니다.ProfileClient): 기본 경로/BackHeader(약관·탈퇴 화면):fallbackHrefprop을 추가했고 기본값은//profile확인
navigation.test.ts: 방문 기록이 있을 때 / 없을 때profile.test.ts: 공백만 있는 닉네임 거부, 앞뒤 공백이 있어도 글자가 있으면 통과turbo run typecheck lint:check test(web, shared), prettier: 통과/terms를 열고 뒤로가기💬리뷰 요구사항(선택)
/(비로그인이면 로그인 화면), 탈퇴는/profile로 보내는 게 맞는지 봐주세요.@coderabbitai ignore
🤖 Generated with Claude Code