Repository navigation
[GLB-185] fix(image-metadata): 자르기 완료를 연타해도 한 번만 처리되게 잠금 추가 - #375
Merged
Merged
Conversation
- createCroppedImage에 중복 실행 방지가 없어 빠르게 두 번 누르면 자른 사진이 여러 번 저장됐음
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
apps/web/src/components/imageMetadata/ImageCropModal.tsxcreateCroppedImage에 처리 중 잠금을 넣었습니다.isCroppingRef)로 잠가, 화면이 다시 그려지기 전에 들어온 두 번째 클릭도 막습니다.isCropping)로 헤더 "완료" 버튼을 비활성화합니다(rightButtonDisabled).티켓의 두 번째 문제(같은 사진 ID 중복 삭제)
useImageMetadata.ts의 삭제 대기 목록(setPendingDeletePhotoIds)이 지금 develop에는 없습니다(pendingDelete검색 0건).다른 PR과의 충돌
useImageMetadata.ts)과 각각 임시로 합쳐 봤을 때 충돌이 없었습니다.확인
turbo run typecheck lint:check test, prettier: 통과@coderabbitai ignore
🤖 Generated with Claude Code