Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert swapping help and description of presentation-role-conflict #4738

Merged
merged 2 commits into from
Mar 31, 2025
+5 −5
Merged

chore: revert swapping help and description of presentation-role-conflict #4738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e07b16
chore: revert swapping help and description of presentation-role-conf…
straker Mar 27, 2025
2e732b6
update
straker Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/rule-descriptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Rules that do not necessarily conform to WCAG success criterion but are industry
| [landmark-unique](https://dequeuniversity.com/rules/axe/4.10/landmark-unique?application=RuleDescription) | Ensure landmarks are unique | Moderate | cat.semantics, best-practice | failure | |
| [meta-viewport-large](https://dequeuniversity.com/rules/axe/4.10/meta-viewport-large?application=RuleDescription) | Ensure <meta name="viewport"> can scale a significant amount | Minor | cat.sensory-and-visual-cues, best-practice | failure | |
| [page-has-heading-one](https://dequeuniversity.com/rules/axe/4.10/page-has-heading-one?application=RuleDescription) | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | failure | |
| [presentation-role-conflict](https://dequeuniversity.com/rules/axe/4.10/presentation-role-conflict?application=RuleDescription) | Ensure elements marked as presentational are consistently ignored | Minor | cat.aria, best-practice, ACT | failure | [46ca7f](https://act-rules.github.io/rules/46ca7f) |
| [presentation-role-conflict](https://dequeuniversity.com/rules/axe/4.10/presentation-role-conflict?application=RuleDescription) | Ensure elements marked as presentational do not have global ARIA or tabindex so that all screen readers ignore them | Minor | cat.aria, best-practice, ACT | failure | [46ca7f](https://act-rules.github.io/rules/46ca7f) |
| [region](https://dequeuniversity.com/rules/axe/4.10/region?application=RuleDescription) | Ensure all page content is contained by landmarks | Moderate | cat.keyboard, best-practice | failure | |
| [scope-attr-valid](https://dequeuniversity.com/rules/axe/4.10/scope-attr-valid?application=RuleDescription) | Ensure the scope attribute is used correctly on tables | Moderate | cat.tables, best-practice | failure | |
| [skip-link](https://dequeuniversity.com/rules/axe/4.10/skip-link?application=RuleDescription) | Ensure all skip links have a focusable target | Moderate | cat.keyboard, best-practice | failure, needs review | |
Expand Down
4 changes: 2 additions & 2 deletions lib/rules/presentation-role-conflict.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"tags": ["cat.aria", "best-practice", "ACT"],
"actIds": ["46ca7f"],
"metadata": {
"description": "Ensure elements marked as presentational are consistently ignored",
"help": "Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them"
"description": "Ensure elements marked as presentational do not have global ARIA or tabindex so that all screen readers ignore them",
"help": "Elements marked as presentational should be consistently ignored"
},
"all": [],
"any": [],
Expand Down
4 changes: 2 additions & 2 deletions locales/_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@
"help": "Page should contain a level-one heading"
},
"presentation-role-conflict": {
"description": "Ensure elements marked as presentational are consistently ignored",
"help": "Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them"
"description": "Ensure elements marked as presentational do not have global ARIA or tabindex so that all screen readers ignore them",
"help": "Elements marked as presentational should be consistently ignored"
},
"region": {
"description": "Ensure all page content is contained by landmarks",
Expand Down