Clean up deprecations#558
Open
grimmy wants to merge 1 commit into
Open
Conversation
Collaborator
|
Does this need a #if !GLIB_CHECK_VERSION(2, 68, 0) && !PURPLE_VERSION_CHECK(2, 14, 2)
#define g_memdup2(mem, size) g_memdup((mem), (size))
#endifin glibcompat.h? |
Collaborator
Author
|
I knew I was forgetting something... they had a suggestion for it when this got added. I need to double check what it is quick. |
Collaborator
Author
|
oh did we put that into purple2 as well...? |
We end up ignoring a bunch of them as you can't inline ignore the macro deprecations or I just don't know how.
Collaborator
Author
|
Okay all fixed up. |
Collaborator
Author
|
@EionRobb ping |
EionRobb
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We end up ignoring a bunch of them as you can't inline ignore the macro deprecations or I just don't know how.