-
-
Notifications
You must be signed in to change notification settings - Fork 2k
refactor: remove unused sorting key bindings from various views #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@derailed I have resolved the merge conflicts |
|
@uozalp Thank you for this cleanup! I think it looks good but for views that are k9s specific or non k8s resources we should keep the key sorts as these would not change and allow for quick sort without requiring users to |
|
@derailed This creates conflicts in: Helm History, Helm Chart, Workload views ( I see three options to resolve this:
Personally, I lean towards option 3 because:
I only use port forwards, and it often has 0-2 entries, honestly don't need to sort such small tables. I'm happy to implement whichever approach you prefer for the project. What do you think? Alias
Port Forward
Reference
Image Scan/Vulnerability
Helm History
Helm Char
Workload
Vulnerability Extender
|
|
@umut Good point! I do think What do you think? |
|
@derailed I added shortcut bindings for the non-k8s views, changed the column-sort selection to |
This resolves #3660
Note: PR #3650 depends on this change.