Vite migration - #448
Merged
Merged
Conversation
master moved forward while this PR was open with a parallel effort (f2daca4, 0c2dce1, 7e19ed1) that took webpack in the opposite direction: npm audit fix --force to webpack 4->5, Jest 26->30, ESLint 6->10 in place, rather than replacing webpack/Jest with Vite/Vitest. Both efforts independently hit and fixed the same underlying issues (Jasmine spyOn syntax, the game.spec.ts timing flakiness, the same dead-code lint findings, the eslint flat-config move) since they're inherent to the TS/ESLint major-version jump, not particular to either build tool. Superseding the webpack-specific parts: this commit rebuilds the vite-migration branch on top of master's new tip, keeping the Vite/vite-plugin-pwa/Vitest approach (which removes webpack/Jest outright, resolving the same npm audit findings by elimination rather than upgrade) and dropping master's webpack5/Jest30-specific changes. Shared tooling versions (eslint, eslint-config-prettier, eslint-plugin-prettier, typescript-eslint, prettier, globals, @eslint/js) already matched exactly between the two efforts. Re-verified end to end after the rebase: tsc --noEmit, eslint, all 49 vitest tests, vite build, and a dev-server smoke check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.