Bug/sensors unavailable#103
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a configurable HTTP timeout setting for the Enpal Box data scraping endpoint. The timeout was previously hardcoded to 30 seconds in
sensor.py. It is now exposed as a user-configurable option (range: 10–120 seconds) in both the initial setup flow and the options flow, with full DE/EN translations.Changed files:
const.py– New constantDEFAULT_TIMEOUT = 30sensor.py– Reads timeout from config entry options instead of using a hardcoded valueconfig_flow.py– Addedtimeoutfield to setup step, options flow, and all related schemas/processingtranslations/en.json– English label for timeout fieldtranslations/de.json– German label for timeout fieldmanifest.json– Version bump to2.3.1Motivation and Context
Users with slow Enpal Box web interfaces frequently experienced sensors switching to "Unavailable" because the hardcoded 30-second HTTP timeout was exceeded. This is especially common on first-generation Enpal boxes under load. By making the timeout configurable, users can increase it (e.g. to 60–90s) to avoid transient unavailability without requiring a code change.
How Has This Been Tested?
config_flow.py,const.py, andsensor.pyhave no lint/type errorstimeoutoption fall back toDEFAULT_TIMEOUT = 30Screenshots (if appropriate):
N/A — UI change is a single additional integer input field in the configuration/options dialog.
Types of changes
Checklist: