#727 wip, added tests

modeltranslation/tests/migrations/0002_alter_manytomanyfieldmodel_self_call_1_and_more.py

@@ -0,0 +1,131 @@
+# Generated by Django 4.2.10 on 2024-04-20 11:15
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("tests", "0001_initial"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_1",
+            field=models.ManyToManyField(to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_1_de",
+            field=models.ManyToManyField(null=True, to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_1_en",
+            field=models.ManyToManyField(null=True, to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_2",
+            field=models.ManyToManyField(to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_2_de",
+            field=models.ManyToManyField(null=True, to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.AlterField(
+            model_name="manytomanyfieldmodel",
+            name="self_call_2_en",
+            field=models.ManyToManyField(null=True, to="tests.manytomanyfieldmodel"),
+        ),
+        migrations.CreateModel(
+            name="SecondSetNullForeignKeyModel",
+            fields=[
+                (
+                    "id",
+                    models.AutoField(
+                        auto_created=True,
+                        primary_key=True,
+                        serialize=False,
+                        verbose_name="ID",
+                    ),
+                ),
+                (
+                    "test",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+                (
+                    "test_de",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+                (
+                    "test_en",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+            ],
+            options={
+                "abstract": False,
+            },
+        ),
+        migrations.CreateModel(
+            name="FirstSetNullForeignKeyModel",
+            fields=[
+                (
+                    "id",
+                    models.AutoField(
+                        auto_created=True,
+                        primary_key=True,
+                        serialize=False,
+                        verbose_name="ID",
+                    ),
+                ),
+                (
+                    "test",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+                (
+                    "test_de",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+                (
+                    "test_en",
+                    models.ForeignKey(
+                        null=True,
+                        on_delete=django.db.models.deletion.SET_NULL,
+                        related_name="%(app_label)s_%(class)s_set",
+                        to="tests.testmodel",
+                    ),
+                ),
+            ],
+            options={
+                "abstract": False,
+            },
+        ),
+    ]

modeltranslation/tests/migrations/0003_firstsetnullforeignkeymodel_translated_and_more.py

@@ -0,0 +1,42 @@
+# Generated by Django 4.2.10 on 2024-04-21 06:39
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("tests", "0002_alter_manytomanyfieldmodel_self_call_1_and_more"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="firstsetnullforeignkeymodel",
+            name="translated",
+            field=models.TextField(blank=True, default=""),
+        ),
+        migrations.AddField(
+            model_name="firstsetnullforeignkeymodel",
+            name="translated_de",
+            field=models.TextField(blank=True, default="", null=True),
+        ),
+        migrations.AddField(
+            model_name="firstsetnullforeignkeymodel",
+            name="translated_en",
+            field=models.TextField(blank=True, default="", null=True),
+        ),
+        migrations.AddField(
+            model_name="secondsetnullforeignkeymodel",
+            name="translated22",
+            field=models.TextField(blank=True, default=""),
+        ),
+        migrations.AddField(
+            model_name="secondsetnullforeignkeymodel",
+            name="translated22_de",
+            field=models.TextField(blank=True, default="", null=True),
+        ),
+        migrations.AddField(
+            model_name="secondsetnullforeignkeymodel",
+            name="translated22_en",
+            field=models.TextField(blank=True, default="", null=True),
+        ),
+    ]

modeltranslation/tests/models.py

@@ -95,6 +95,25 @@ class ForeignKeyModel(models.Model):
         on_delete=models.CASCADE,
     )
 
+class SetNullForeignKeyBaseModel(models.Model):
+    test = models.ForeignKey(
+        TestModel,
+        null=True,
+        on_delete=models.SET_NULL,
+        related_name="%(app_label)s_%(class)s_set",
+    )
+
+    class Meta:
+        abstract = True
+
+
+class FirstSetNullForeignKeyModel(SetNullForeignKeyBaseModel):
+    translated = models.TextField(default="", blank=True)
+
+
+class SecondSetNullForeignKeyModel(SetNullForeignKeyBaseModel):
+    translated22 = models.TextField(default="", blank=True)
+
 
 class OneToOneFieldModel(models.Model):
     title = models.CharField(gettext_lazy("title"), max_length=255)

modeltranslation/tests/tests.py

@@ -1182,6 +1182,10 @@ def test_indonesian(self):
         field = models.ForeignKeyModel._meta.get_field("test")
         assert field.attname != build_localized_fieldname(field.name, "id")
 
+    def test_multiple_translated_foreign_keys_delete_foreign_obj(self):
+        test = models.TestModel.objects.create(title="test")
+        test.delete()
+
 
 class ManyToManyFieldsTest(ModeltranslationTestBase):
     @classmethod

modeltranslation/tests/translation.py

@@ -85,6 +85,26 @@ class ForeignKeyModelTranslationOptions(TranslationOptions):
     )
 
 
+@register(models.SetNullForeignKeyBaseModel)
+class SetNullForeignKeyBaseModelTranslationOptions(TranslationOptions):
+    fields = [
+        "test",
+    ]
+
+@register(models.FirstSetNullForeignKeyModel)
+class FirstSetNullForeignKeyModelTranslationOptions(SetNullForeignKeyBaseModelTranslationOptions, TranslationOptions):
+    fields = [
+        "translated",
+    ]
+
+@register(models.SecondSetNullForeignKeyModel)
+class SecondSetNullForeignKeyModelTranslationOptions(SetNullForeignKeyBaseModelTranslationOptions, TranslationOptions):
+    fields = [
+        "translated22",
+    ]
+
+
+
 @register(models.OneToOneFieldModel)
 class OneToOneFieldModelTranslationOptions(TranslationOptions):
     fields = (

pyproject.toml

@@ -23,6 +23,7 @@ pytest-sugar = "*"
 pytest-django = "*"
 django-stubs = "^4.2.7"
 mypy = "^1.8.0"
+pillow = "^10.3.0"
 
 [tool.ruff]
 line-length = 100