Skip to content

feat: add storagePrefix option to react sdk#1216

Open
gustavofabro-i2p wants to merge 4 commits intodescope:mainfrom
gustavofabro-i2p:feat-react-storage-prefix
Open

feat: add storagePrefix option to react sdk#1216
gustavofabro-i2p wants to merge 4 commits intodescope:mainfrom
gustavofabro-i2p:feat-react-storage-prefix

Conversation

@gustavofabro-i2p
Copy link

Related Issues

Related PRs

#265

Description

Add storagePrefix option to react SDK

Must

  • Tests
  • Documentation (if applicable)

@vercel
Copy link

vercel bot commented Sep 17, 2025

@gustavofabro is attempting to deploy a commit to the descope Team on Vercel.

A member of the Team first needs to authorize it.

@wiz-d45ab51820
Copy link
Contributor

wiz-d45ab51820 bot commented Sep 17, 2025

Wiz Scan Summary

Displaying only findings that violated a policy

Scanner Findings
Vulnerability Finding Vulnerabilities 3 Critical
Data Finding Sensitive Data -
Total 3 Critical

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Vulnerability Finding on line 0

More Details

Vulnerabilities [form-data:4.0.0]

Name Severity Source Fixed version CVSS score CVSS exploitability score Has public exploit Has CISA KEV exploit
CVE-2025-7783 Critical GHSA-fjxv-7rqg-78g4 4.0.4 9.4 - false false

To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason

If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Vulnerability Finding on line 0

More Details

Vulnerabilities [next:14.2.21]

Name Severity Source Fixed version CVSS score CVSS exploitability score Has public exploit Has CISA KEV exploit
CVE-2025-29927 Critical GHSA-f82v-jwr5-mffw 14.2.25 9.1 3.9 true false
CVE-2025-32421 Low GHSA-qpjv-v59x-3qc4 14.2.24 3.7 2.2 false false
CVE-2025-48068 Low GHSA-3h52-269p-cp9r 14.2.30 2.3 2.8 false false
CVE-2025-55173 Medium GHSA-xv57-4mr9-wg8v 14.2.31 4.3 2.8 false false
CVE-2025-57752 Medium GHSA-g5qg-72qw-gw5v 14.2.31 6.2 2.5 false false
CVE-2025-57822 Medium GHSA-4342-x723-ch2f 14.2.32 8.2 3.9 false false

To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason

If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Vulnerability Finding on line 0

More Details

Vulnerabilities [next:14.2.10]

Name Severity Source Fixed version CVSS score CVSS exploitability score Has public exploit Has CISA KEV exploit
CVE-2024-51479 High GHSA-7gfc-8cq8-jh5f 14.2.15 7.5 3.9 false false
CVE-2024-56332 Medium GHSA-7m27-7ghc-44w9 14.2.21 5.3 3.9 false false
CVE-2025-29927 Critical GHSA-f82v-jwr5-mffw 14.2.25 9.1 3.9 true false
CVE-2025-32421 Low GHSA-qpjv-v59x-3qc4 14.2.24 3.7 2.2 false false
CVE-2025-48068 Low GHSA-3h52-269p-cp9r 14.2.30 2.3 2.8 false false
CVE-2025-55173 Medium GHSA-xv57-4mr9-wg8v 14.2.31 4.3 2.8 false false
CVE-2025-57752 Medium GHSA-g5qg-72qw-gw5v 14.2.31 6.2 2.5 false false
CVE-2025-57822 Medium GHSA-4342-x723-ch2f 14.2.32 8.2 3.9 false false

To ignore this finding as an exception, reply to this conversation with #wiz_ignore reason

If you'd like to ignore this finding in all future scans, add an exception in the .wiz file (learn more) or create an Ignore Rule (learn more).

Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat! thanks for the contribution!

there are other usage of the storage prefixes that I'm not sure that are considered, such as

  • Descope component (descope-wc inside web-compoent package) also creates an sdk
  • Widgets as well

we need to address those as well

getExternalToken,
storagePrefix,
});
}, [projectId, baseUrl, sessionTokenViaCookie, getExternalToken]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage prefix should also be in the deps array

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@gustavofabro-i2p
Copy link
Author

very neat! thanks for the contribution!

there are other usage of the storage prefixes that I'm not sure that are considered, such as

  • Descope component (descope-wc inside web-compoent package) also creates an sdk
  • Widgets as well

we need to address those as well

The widget components have been updated, but I'm not sure about descope-wc. The React wrapper for the web component is overriding persistToken as false (global SDK will handle token management in this case), so from our tests, there's no effect if I pass the storagePrefix to the React Descope component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants