Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
View your CI Pipeline Execution ↗ for commit db96b76
☁️ Nx Cloud last updated this comment at |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the flow API from v1 to v2, introducing a new delimiter pattern for execution IDs. The change replaces |#| with --- as the delimiter and updates all flow API endpoints from /v1/flow/ to /v2/flow/.
Changes:
- Updated flow API endpoints from v1 to v2 (
/v1/flow/start→/v2/flow/start,/v1/flow/next→/v2/flow/next) - Changed execution ID delimiter from
|#|to---in regex patterns and test data - Updated all corresponding tests to reflect the new API version and delimiter format
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/sdks/core-js-sdk/src/constants/apiPaths.ts | Updated flow API paths from v1 to v2 |
| packages/sdks/core-js-sdk/test/sdk/flow.test.ts | Updated test expectations for v2 API endpoints |
| packages/sdks/web-js-sdk/src/enhancers/withFlowNonce/constants.ts | Updated flow path constants to v2 |
| packages/sdks/web-js-sdk/src/enhancers/withFlowNonce/helpers.ts | Updated regex pattern to parse new --- delimiter |
| packages/sdks/web-js-sdk/test/sdk.test.ts | Updated test expectations for v2 flow/start endpoint |
| packages/sdks/web-js-sdk/test/lastLoggedInUser.test.ts | Updated test expectations for v2 flow endpoints |
| packages/sdks/web-js-sdk/test/flowNonce.test.ts | Updated test mock data to use --- delimiter and v2 endpoints |
| packages/sdks/web-js-sdk/test/beforeRequest-dtd.test.ts | Updated test paths to v2 flow/start endpoint |
| packages/sdks/web-component/src/lib/helpers/helpers.ts | Updated regex pattern to extract flow ID using new delimiter |
| packages/sdks/web-component/test/helpers/index.test.ts | Updated test data to use --- delimiter format |
| packages/sdks/web-component/e2e/descope-wc.spec.ts | Updated E2E test mock response to use new delimiter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asafshen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
https://github.com/descope/etc/issues/13930
Description
support v2 routes that will basically introduce a new delimiter
---(instead|#|for v1)