feat(web-js-sdk): export last user helper functions#1332
Open
meirarmon wants to merge 1 commit intodescope:mainfrom
Open
feat(web-js-sdk): export last user helper functions#1332meirarmon wants to merge 1 commit intodescope:mainfrom
meirarmon wants to merge 1 commit intodescope:mainfrom
Conversation
Export setLastUserLoginId, setLastUserDisplayName, removeLastUserLoginId, and removeLastUserDisplayName from the public API. These functions already exist internally but are not exported, making it impossible for consumers to programmatically set or clear the last authenticated user without directly accessing localStorage keys.
|
@meirarmon is attempting to deploy a commit to the descope Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export the last authenticated user helper functions from the public API:
setLastUserLoginId(loginId: string)setLastUserDisplayName(displayName: string)removeLastUserLoginId()removeLastUserDisplayName()The getter functions (
getLastUserLoginId,getLastUserDisplayName) are also exported for completeness, though they were already accessible on the SDK instance.Motivation
Fixes #1331
These functions already exist in
enhancers/withLastLoggedInUser/helpers.tsbut are not exported from the package. This makes it impossible for consumers to programmatically set or clear the last authenticated user without directly accessing the internal localStorage keys.Changes
packages/sdks/web-js-sdk/src/index.tspackages/sdks/web-js-sdk/test/umd.test.ts