Skip to content

feat: Forward totp.key to screen state #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomerlichtash wants to merge 7 commits into
base: main
Choose a base branch
from
+45 −2
Open

feat: Forward totp.key to screen state #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f1c651a
Forward totp.key to screen state
tomerlichtash Feb 18, 2026
d7b5ea9
Merge branch 'main' into fix-13800
tomerlichtash Feb 18, 2026
9432735
cleanup
tomerlichtash Feb 18, 2026
15d08d7
Merge branch 'fix-13800' of github.com:descope/descope-js into fix-13800
tomerlichtash Feb 18, 2026
210d2fd
cr fixes
tomerlichtash Feb 18, 2026
30a2c27
cleanup
tomerlichtash Feb 18, 2026
9fcd9f5
add tests
tomerlichtash Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/sdks/web-component/src/lib/helpers/templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,11 @@ export const updateScreenFromScreenState = (
baseEle: HTMLElement,
screenState?: ScreenState,
) => {
replaceElementInputs(baseEle, screenState?.inputs);
const screenInputs = {
...screenState?.inputs,
...(screenState?.totp?.key ? { 'totp.key': screenState.totp.key } : {}),
Copy link
Collaborator

@nirgur nirgur Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see we are passing the other totp keys here,
so why do we need special treatment for this one?

Copy link
Member Author

@tomerlichtash tomerlichtash Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we want to support the population of this one in a read-only input TOTP Key editor component.

};
replaceElementInputs(baseEle, screenInputs);
replaceElementInputs(baseEle, screenState?.form);
};

Expand Down
2 changes: 1 addition & 1 deletion packages/sdks/web-component/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export interface ScreenState {
inputs?: Record<string, string>; // Backward compatibility
lastAuth?: LastAuthState;
project?: Project;
totp?: { image?: string; provisionUrl?: string };
totp?: { image?: string; provisionUrl?: string; key?: string };
notp?: { image?: string; redirectUrl?: string };
selfProvisionDomains?: unknown;
user?: unknown;
Expand Down
39 changes: 39 additions & 0 deletions packages/sdks/web-component/test/helpers/templates.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,45 @@ describe('templates', () => {
await waitFor(() => screen.getByShadowDisplayValue('email1'));
});

it('should forward totp.key from screenState to inputs', async () => {
document.body.innerHTML = `<div>
<input class="descope-input" name="totp.key">
</div>`;

updateScreenFromScreenState(document.body, {
totp: { key: 'my-totp-key' },
});
await waitFor(() => screen.getByShadowDisplayValue('my-totp-key'));
});

it('should forward totp.key alongside other inputs', async () => {
document.body.innerHTML = `<div>
<input class="descope-input" name="email">
<input class="descope-input" name="totp.key">
</div>`;

updateScreenFromScreenState(document.body, {
inputs: { email: 'email1' },
totp: { key: 'totp-key-123' },
});
await waitFor(() => screen.getByShadowDisplayValue('email1'));
await waitFor(() => screen.getByShadowDisplayValue('totp-key-123'));
});

it('should not set totp.key input when totp is missing', async () => {
document.body.innerHTML = `<div>
<input class="descope-input" name="totp.key">
</div>`;

updateScreenFromScreenState(document.body, {
inputs: { email: 'email1' },
});
const input = document.querySelector(
'input[name="totp.key"]',
) as HTMLInputElement;
expect(input.value).toBe('');
});

it('should handle descope form', async () => {
document.body.innerHTML = `<div>
<input class="descope-input" name="email"></input>
Expand Down
Loading