feat: expose externalToken on AuthenticationResponse - #150
Conversation
|
🐕 Review complete — View session on Shuni Portal 🐾 |
🐕 Suggested ReviewersThe review assignment focuses on contributors with comprehensive coverage of the affected files and core familiarity with the codebase to ensure a broad and effective review.
Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best. |
There was a problem hiding this comment.
🐕 Shuni's Review
Threads externalToken from the server JWT response through JWTResponse.convert() onto the public AuthenticationResponse, matching the Flutter/web SDKs.
No issues found — good bones! 🦴
Decoding is auto-synthesized, the flow auth path carries it through, the other init call sites (migrate / provided-session) correctly default to nil, and both present/absent cases are tested. Woof!
Related Issues
https://github.com/descope/etc/issues/16830
Related PRs
descope/descope-kotlin#336
descope/descope-js#1435
Description
AuthenticationResponse.externalToken: String?from the server auth responseJWTResponseand passed throughconvert(), matching the Flutter and web SDKsMust