Skip to content

feat: expose externalToken on AuthenticationResponse - #150

Merged
itaihanski merged 1 commit into
mainfrom
feat/external-token
Jul 12, 2026
Merged

feat: expose externalToken on AuthenticationResponse#150
itaihanski merged 1 commit into
mainfrom
feat/external-token

Conversation

@itaihanski

@itaihanski itaihanski commented Jul 12, 2026

Copy link
Copy Markdown
Member

Related Issues

https://github.com/descope/etc/issues/16830

Related PRs

descope/descope-kotlin#336
descope/descope-js#1435

Description

  • Populate AuthenticationResponse.externalToken: String? from the server auth response
  • Decoded on JWTResponse and passed through convert(), matching the Flutter and web SDKs

Must

  • Tests
  • Documentation

@shuni-bot

shuni-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

🐕 Suggested Reviewers

The review assignment focuses on contributors with comprehensive coverage of the affected files and core familiarity with the codebase to ensure a broad and effective review.

Reviewer Reason
shilgapira Shilgapira has extensive commit history across multiple files involved in this change, including HTTP handling, routes, and response types, making them well-suited to review both the functional and integration aspects.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni's Review

Threads externalToken from the server JWT response through JWTResponse.convert() onto the public AuthenticationResponse, matching the Flutter/web SDKs.

No issues found — good bones! 🦴

Decoding is auto-synthesized, the flow auth path carries it through, the other init call sites (migrate / provided-session) correctly default to nil, and both present/absent cases are tested. Woof!

@itaihanski
itaihanski requested a review from shilgapira July 12, 2026 08:49
@itaihanski
itaihanski merged commit 1d0c2b5 into main Jul 12, 2026
9 checks passed
@itaihanski
itaihanski deleted the feat/external-token branch July 12, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants