Conversation
…chAll method feat: renamed option to set paging size by using the Limit option instead of the Size option (breaking but not in use yet by clients so not worth "dirtying" the API with unneeded aliases) chore: added files generated by running the local example to be ignored by gitleaks to avoid false leaks from appearing in pre-commit hooks
dorsha
reviewed
Jan 9, 2025
Member
dorsha
left a comment
dorsha
left a comment
There was a problem hiding this comment.
Cool, let's keep old search tests as well
Contributor
Author
|
@dorsha thanks! I re-added the old search tests, ready for review again 🙏 |
dorsha
approved these changes
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: https://github.com/descope/etc/issues/8887
Added a new Audit.SearchAll API which also returns the total number of search results, same as in the User.SearchAll API. Marked the existing Audit.Search method as Deprecated.
Additional minor fixes:
Limitoption instead of theSizeoption to adhere to the same API used in User.SearchAll (breaking change, but breaks a new API which is not in use yet, so not worth "dirtying" the API with unneeded backwards compatibility aliases)Must