Skip to content

feat: renamed input parameters to reflect new capability in management service, allowing sending either loginId or userId#494

Merged
yosiharan merged 4 commits intomainfrom
support-userid-as-idenfier-in-mgmt-update-api-single-parameter
Jan 23, 2025
Merged

feat: renamed input parameters to reflect new capability in management service, allowing sending either loginId or userId#494
yosiharan merged 4 commits intomainfrom
support-userid-as-idenfier-in-mgmt-update-api-single-parameter

Conversation

@yosiharan
Copy link
Contributor

Description

Part of the PRs resolving: https://github.com/descope/etc/issues/2515

Depends on

https://github.com/descope/managementservice/pull/1612

Must

  • Tests
  • Documentation (if applicable)

…ement service, allowing sending either loginId or userId
@yosiharan yosiharan marked this pull request as draft January 20, 2025 10:03
@yosiharan
Copy link
Contributor Author

Setting as draft to prevent merging before dependent PR is merged

@yosiharan yosiharan requested a review from dorsha January 20, 2025 10:04
@yosiharan yosiharan changed the title refactor: renamed input parameters to reflect new capability in management service, allowing sending either loginId or userId feat: renamed input parameters to reflect new capability in management service, allowing sending either loginId or userId Jan 20, 2025
@dorsha
Copy link
Member

dorsha commented Jan 20, 2025

Cool, let's also fix readme/examples explaining the options.

@yosiharan yosiharan marked this pull request as ready for review January 20, 2025 11:25
@yosiharan yosiharan marked this pull request as draft January 20, 2025 11:25
@yosiharan
Copy link
Contributor Author

@dorsha I updated the readme where relevant and added another manual example 👍 🙏

Copy link
Member

@dorsha dorsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yosiharan yosiharan marked this pull request as ready for review January 23, 2025 11:16
@yosiharan yosiharan enabled auto-merge (squash) January 23, 2025 11:16
@yosiharan yosiharan merged commit c825f9d into main Jan 23, 2025
4 checks passed
@yosiharan yosiharan deleted the support-userid-as-idenfier-in-mgmt-update-api-single-parameter branch January 23, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants