fix: revert "fix: project snapshot import exclude list"#691
Merged
Conversation
This reverts commit e7f2a2e.
dorsha
approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts a previously introduced snapshot-import “exclude list” capability by removing the excludes field from the import request type and backing out the related tests/docs.
Changes:
- Remove
Excludesfromdescope.ImportSnapshotRequest. - Simplify project snapshot import tests to no longer assert/emit
excludes. - Update README snapshot import example accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
descope/types.go |
Removes ImportSnapshotRequest.Excludes from the public request type. |
descope/internal/mgmt/project_test.go |
Removes tests/assertions around serializing the excludes field. |
descope/internal/mgmt/audit_test.go |
Adjusts audit webhook filter values used/expected in the test. |
README.md |
Removes documentation/example usage of snapshot import excludes. |
Comments suppressed due to low confidence (1)
descope/types.go:1132
- Removing
ImportSnapshotRequest.Excludesis a source-breaking change for SDK consumers who may already be using that field. If the server/API no longer supports excludes, consider keeping the field for backward compatibility (e.g., deprecate it and ensure it is not sent over the wire), or ensure this ships with an explicit breaking-change notice / major version bump policy for the SDK.
type ImportSnapshotRequest struct {
// All project settings and configurations represented as JSON files
Files map[string]any `json:"files"`
// An optional map of project entities and their secrets that will be
// injected into the snapshot before import (see below)
InputSecrets *SnapshotSecrets `json:"inputSecrets,omitempty"`
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #690