Skip to content

fix: revert "fix: project snapshot import exclude list"#691

Merged
dorsha merged 1 commit intomainfrom
revert-690-import-project-snapshot-exclude
Feb 19, 2026
Merged

fix: revert "fix: project snapshot import exclude list"#691
dorsha merged 1 commit intomainfrom
revert-690-import-project-snapshot-exclude

Conversation

@ruvenzx
Copy link
Contributor

@ruvenzx ruvenzx commented Feb 19, 2026

Reverts #690

@ruvenzx ruvenzx requested a review from dorsha February 19, 2026 08:44
@ruvenzx ruvenzx self-assigned this Feb 19, 2026
Copilot AI review requested due to automatic review settings February 19, 2026 08:44
@ruvenzx ruvenzx changed the title Revert "fix: project snapshot import exclude list" fix: revert "fix: project snapshot import exclude list" Feb 19, 2026
@dorsha dorsha enabled auto-merge (squash) February 19, 2026 08:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts a previously introduced snapshot-import “exclude list” capability by removing the excludes field from the import request type and backing out the related tests/docs.

Changes:

  • Remove Excludes from descope.ImportSnapshotRequest.
  • Simplify project snapshot import tests to no longer assert/emit excludes.
  • Update README snapshot import example accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
descope/types.go Removes ImportSnapshotRequest.Excludes from the public request type.
descope/internal/mgmt/project_test.go Removes tests/assertions around serializing the excludes field.
descope/internal/mgmt/audit_test.go Adjusts audit webhook filter values used/expected in the test.
README.md Removes documentation/example usage of snapshot import excludes.
Comments suppressed due to low confidence (1)

descope/types.go:1132

  • Removing ImportSnapshotRequest.Excludes is a source-breaking change for SDK consumers who may already be using that field. If the server/API no longer supports excludes, consider keeping the field for backward compatibility (e.g., deprecate it and ensure it is not sent over the wire), or ensure this ships with an explicit breaking-change notice / major version bump policy for the SDK.
type ImportSnapshotRequest struct {
	// All project settings and configurations represented as JSON files
	Files map[string]any `json:"files"`
	// An optional map of project entities and their secrets that will be
	// injected into the snapshot before import (see below)
	InputSecrets *SnapshotSecrets `json:"inputSecrets,omitempty"`
}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dorsha dorsha merged commit a1d6f11 into main Feb 19, 2026
22 of 23 checks passed
@dorsha dorsha deleted the revert-690-import-project-snapshot-exclude branch February 19, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants