Skip to content

[Feat] Enhance SSO model#240

Merged
shilgapira merged 11 commits intomainfrom
feat/sso-enhance
Feb 19, 2026
Merged

[Feat] Enhance SSO model#240
shilgapira merged 11 commits intomainfrom
feat/sso-enhance

Conversation

@LioriE
Copy link
Contributor

@LioriE LioriE commented Feb 8, 2026

Related Issues

Resolves https://github.com/descope/etc/issues/13885

Related

https://github.com/descope/managementservice/pull/3522

Description

add mandatory_user_attributes , sso_domains_required, groups_attribute_name_required , limit_mapping_to_mandatory_attributes to the sso model

Must

  • Acceptance Tests
  • Schema Compatibility
  • Documentation Updates

add mandatory_user_attributes , sso_domains_required, groups_attribute_name_required , limit_mapping_to_mandatory_attributes to the sso model
Copilot AI review requested due to automatic review settings February 8, 2026 09:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enhances the SSO model by adding support for mandatory user attributes and additional SSO requirement flags, including doc and acceptance-test updates.

Changes:

  • Added new SSO schema/model fields: mandatory_user_attributes, limit_mapping_to_mandatory_attributes, sso_domains_required, groups_attribute_name_required.
  • Implemented mapping logic to translate between Terraform nested objects and API’s mandatoryUserAttributes string list format (including special attributes and custom prefixing).
  • Extended generated docs and acceptance tests to cover the new attributes.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
internal/models/project/authentication/sso.go Adds new SSO fields + conversion helpers between Terraform schema and API payload.
internal/models/project/authentication/authentication_test.go Adds test steps for new SSO attributes.
internal/docs/models.go Injects docs for the new nested MandatoryUserAttribute schema.
internal/docs/docs.go Adds documentation strings for new SSO fields and nested attributes.
docs/resources/project.md Updates generated resource docs with new fields and nested schema.
docs/raw/project/authentication/sso.md Updates raw docs to include new SSO fields and nested type docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LioriE LioriE requested review from shilgapira and removed request for shilgapira February 8, 2026 12:29
@LioriE LioriE requested a review from shilgapira February 8, 2026 14:33
@LioriE LioriE enabled auto-merge (squash) February 19, 2026 13:13
@shilgapira shilgapira disabled auto-merge February 19, 2026 14:30
@shilgapira shilgapira enabled auto-merge (squash) February 19, 2026 14:31
@shilgapira shilgapira disabled auto-merge February 19, 2026 14:31
@shilgapira shilgapira merged commit 027d38b into main Feb 19, 2026
13 checks passed
@shilgapira shilgapira deleted the feat/sso-enhance branch February 19, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants