Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces centralized package management and refactors infrastructure components by creating a new DevStore.Infra.Core project. The changes consolidate database provider and health check functionality into a dedicated infrastructure layer and standardize NuGet package versioning across the solution.
- Creates a new
DevStore.Infra.Coreproject to house database provider and health check infrastructure components - Implements centralized package version management using
Directory.Packages.props - Updates project references and namespaces to reflect the new infrastructure organization
Reviewed Changes
Copilot reviewed 15 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | Introduces centralized package version management for the entire solution |
| DevStore.slnx | Adds the new infrastructure project to the solution |
| DevStore.Infra.Core/DevStore.Infra.Core.csproj | Creates new infrastructure project with database and health check dependencies |
| DevStore.Infra.Core/DatabaseFlavor/* | Moves database provider classes from WebAPI.Core with updated namespaces |
| DevStore.Infra.Core/Configuration/GenericHealthCheck.cs | Moves health check configuration with updated namespace |
| DevStore.WebAPI.Core/Configuration/ApiCoreConfig.cs | Updates imports to reference new infrastructure project |
| src/web/DevStore.WebApp.Status/Program.cs | Updates namespace references and adds null assertion operator |
| Multiple .csproj files | Removes explicit version numbers to use centralized package management |
src/building-blocks/DevStore.Infra.Core/DatabaseFlavor/ProviderConfiguration.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
DevStore.Infra.Corebuilding block, refactors the database provider and health check infrastructure to reside under this new project, and standardizes NuGet package versioning across the solution. It also updates project references and namespaces to reflect these changes, and simplifies package references in several.csprojfiles.Infrastructure Refactoring and Project Structure:
DevStore.Infra.Coreproject, including its.csprojfile with relevant package references for databases and health checks. (src/building-blocks/DevStore.Infra.Core/DevStore.Infra.Core.csproj)DevStore.WebAPI.CoretoDevStore.Infra.Core, updating namespaces and references accordingly. (src/building-blocks/DevStore.Infra.Core/DatabaseFlavor/*,src/building-blocks/DevStore.Infra.Core/Configuration/GenericHealthCheck.cs) [1] [2] [3] [4] [5]DevStore.Infra.Core. (DevStore.slnx)Codebase Consistency and Dependency Management:
Directory.Packages.propsfile, and removed explicit version numbers from most.csprojfiles to reference shared versions. (Directory.Packages.props, multiple.csprojfiles) [1] [2] [3] [4] [5] [6]usingstatements to reference the new infrastructure project and namespaces. (src/building-blocks/DevStore.WebAPI.Core/Configuration/ApiCoreConfig.cs,src/web/DevStore.WebApp.Status/Program.cs) [1] [2] [3]Minor Cleanups and Improvements:
src/building-blocks/DevStore.Infra.Core/DatabaseFlavor/ProviderConfiguration.cs)These changes collectively modernize the infrastructure layer, improve maintainability, and standardize dependency management throughout the solution.