Conversation
- Register fastqso CLI entry point in pyproject.toml - Add fastqso() driver function; thread fastqso=False flag through fastspec(), fastspec_one(), continuum_specfit(), and emline_specfit() - get_output_dtype(): when fastqso=True, swap galaxy SPECPHOT fields (VDISP, LOGMSTAR, SFR, AGE, ZZSUN, TAUV, DN4000) for QSO-specific fields (PL_SLOPE, PL_AMPLITUDE, FE_VDISP, FE_AMPLITUDE + IVARs) - write_fastspecfit(): add FASTQSO header keyword; name the emission-line extension FASTQSO instead of FASTSPEC in QSO mode - Templates: expose self.feflux, self.fewave, self.agnflux, self.agnwave as instance attributes (previously computed but discarded) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…models) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Templates: add qso_klambda (slope=-1.2), qso_dust_klambda cache, feflux_default (pre-convolved at FE_VDISP_DEFAULT=3000 km/s) - Step 1: sigma_Fe from Fe-window chi2 scan (log-spaced 300-10000 km/s, nuisance 2-PL continuum); find_minima+minfit for sub-grid minimum - Step 2: aperture correction via nuisance PL+Fe (no dust) - Step 3: joint (alpha, tau_v) 2D grid scan with ContinuumTools.attenuate for dust attenuation and energy-balance AGN torus normalization; tauv grid [0, 0.05..5]; A_torus derived (not a free NNLS parameter) - Step 4: final 2-component NNLS at (alpha_best, tauv_best, sigma_fe) - Step 5: full MC loop for all parameter uncertainties (sigma_fe, alpha, tauv, A_PL, A_Fe, A_torus) - io.py: add TAUV, TAUV_IVAR to FASTQSO output columns - qa.py: apply dust attenuation in _build_qso_sed/spectral_models; add tau_V to legend Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fastspec Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…mn QSO fits Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 26371427444Coverage decreased (-3.6%) to 62.118%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[WIP]
@paulmartini @stephjuneau @arjundey @yzfkieran817 @abrodze and many others
At long last, I have an initial implementation of a "fast" QSO fitter called
fastqso, building on work that I started two years ago (e.g., the templates have had AGN models in them for some time) and the "wish list" in #112.Quoting from the new
continuum.qso_continuum_fastspecdocstring:Here's an example run (6.79 sec for 50 Monte Carlo fitting iterations and 0.84 sec with no Monte Carlo):
And here's the current version of the QA:
For comparison, here's the same object fitted with
fastspecand the nominal set of SPS models:This definitely isn't ready for primetime---and there's a lot I'm going to need some help with---but initial reactions are welcome.