Updates for 26.3#30
Open
weaverba137 wants to merge 10 commits into
Open
Conversation
Coverage Report for CI Build 25763423248Coverage remained the same at 1.12%Details
Uncovered Changes
Coverage Regressions3 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the nightly GFA summary script to run on
desimodules/26.3. It currently runs ondesimodules/main, but that will eventually be supplanted.The biggest non-cosmetic code changes are due to API changes in astropy and photutils.
I ran a comparison test as follows:
${DESI_ROOT}/survey/GFA/offline_matched_coadd_ccds_main-thru_20260505.fitsto${DESI_ROOT}/survey/GFA.test.26.3.${DESI_ROOT}/users/desi/GFA/reduced/realtime_matched.test.26.3.desimodules/26.3and this branch, I ran the scriptdesi_gfa_reduce_daily_summaryon nights 20260506, 20260507, 20260508, 20260509, 20260510, 20260511.${DESI_ROOT}/survey/GFA.test.26.3/offline_matched_coadd_ccds_main-thru_20260511.fitsto${DESI_ROOT}/survey/GFA/offline_matched_coadd_ccds_main-thru_20260511.fits. I could not find any numerical differences.${DESI_ROOT}/users/bweaver/JupyterNotebooks/test_gfa_reduce_26.3.ipynb.I'm still working on some test failures.