Skip to content

Updates for 26.3#30

Open
weaverba137 wants to merge 10 commits into
mainfrom
updates-for-26.3
Open

Updates for 26.3#30
weaverba137 wants to merge 10 commits into
mainfrom
updates-for-26.3

Conversation

@weaverba137
Copy link
Copy Markdown
Member

This PR allows the nightly GFA summary script to run on desimodules/26.3. It currently runs on desimodules/main, but that will eventually be supplanted.

The biggest non-cosmetic code changes are due to API changes in astropy and photutils.

I ran a comparison test as follows:

  1. I copied ${DESI_ROOT}/survey/GFA/offline_matched_coadd_ccds_main-thru_20260505.fits to ${DESI_ROOT}/survey/GFA.test.26.3.
  2. I created a separate intermediate reduction directory, ${DESI_ROOT}/users/desi/GFA/reduced/realtime_matched.test.26.3.
  3. With desimodules/26.3 and this branch, I ran the script desi_gfa_reduce_daily_summary on nights 20260506, 20260507, 20260508, 20260509, 20260510, 20260511.
  4. I compared the resulting file ${DESI_ROOT}/survey/GFA.test.26.3/offline_matched_coadd_ccds_main-thru_20260511.fits to ${DESI_ROOT}/survey/GFA/offline_matched_coadd_ccds_main-thru_20260511.fits. I could not find any numerical differences.
  5. I would encourage you to do the comparison yourself. A helper notebook can be found in ${DESI_ROOT}/users/bweaver/JupyterNotebooks/test_gfa_reduce_26.3.ipynb.

I'm still working on some test failures.

@weaverba137 weaverba137 requested a review from sbailey May 12, 2026 21:27
@weaverba137 weaverba137 self-assigned this May 12, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2026

Coverage Report for CI Build 25763423248

Coverage remained the same at 1.12%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 20 uncovered changes across 3 files (0 of 20 lines covered, 0.0%).
  • 3 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
py/gfa_reduce/analysis/util.py 15 0 0.0%
py/gfa_reduce/analysis/segment.py 3 0 0.0%
py/gfa_reduce/analysis/phot.py 2 0 0.0%

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
py/gfa_reduce/analysis/util.py 2 0.0%
py/gfa_reduce/analysis/phot.py 1 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 3841
Covered Lines: 43
Line Coverage: 1.12%
Coverage Strength: 0.01 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants