Skip to content

force-v1-protocol-version-for-outbound-connections #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Parent: feature/proof-of-stake
wants to merge 1 commit into
base: feature/proof-of-stake
Choose a base branch
from
Draft

force-v1-protocol-version-for-outbound-connections #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions lib/remote_node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ func (rn *RemoteNode) HandleVersionMessage(verMsg *MsgDeSoVersion, responseNonce
}

// Verify that the peer's version matches our minimal supported version.
if verMsg.Version < rn.params.MinProtocolVersion {
if verMsg.Version < rn.params.MinProtocolVersion && verMsg.Version != 1 {
return fmt.Errorf("RemoteNode.HandleVersionMessage: Requesting disconnect for id: (%v) "+
"protocol version too low. Peer version: %v, min version: %v", rn.id, verMsg.Version, rn.params.MinProtocolVersion)
}
Expand All @@ -538,7 +538,7 @@ func (rn *RemoteNode) HandleVersionMessage(verMsg *MsgDeSoVersion, responseNonce
// In order to smoothly transition to the PoS fork, we prevent establishing new outbound connections with
// outdated nodes that run on ProtocolVersion1. This is because ProtocolVersion1 nodes will not be able to
// validate the PoS blocks and will be stuck on the PoW chain, unless they upgrade to ProtocolVersion2.
if rn.params.ProtocolVersion == ProtocolVersion2 && rn.IsOutbound() {
if rn.params.ProtocolVersion == ProtocolVersion2 && rn.IsOutbound() && verMsg.Version != 1 {
return fmt.Errorf("RemoteNode.HandleVersionMessage: Requesting disconnect for id: (%v). Version too low. "+
"Outbound RemoteNodes must use at least ProtocolVersion2, instead received version: %v", rn.id, verMsg.Version)
}
Expand Down