Removes 'nvidia' runtime parameter when Docker version is >= 19.03 (n…#166
Open
bgreer101 wants to merge 1 commit intodessa-oss:masterfrom
Open
Removes 'nvidia' runtime parameter when Docker version is >= 19.03 (n…#166bgreer101 wants to merge 1 commit intodessa-oss:masterfrom
bgreer101 wants to merge 1 commit intodessa-oss:masterfrom
Conversation
…ative support starts)
mohammedri
approved these changes
Jun 3, 2020
|
@bgreer101 thanks for the PR! The user acceptance test pipeline is 🔴 now, but a fix is on the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the release of Docker 19.03 there is no longer the need to install nvidia-docker2 to access GPU's. When
atlas-server start -gis called, it appends the 'nvidia' runtime flag which no longer is required nor exists and causes the scheduler to fail to start. This patch only add's the runtime flag if gpu is requested, and docker is <= 19.03