Fixup/spark schemas #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s documentation (r-dbi#599)
Compare to upstream a94cb6a3d236a4b5103442edf7e2b718c3660dde
Only set the current result to null if we are cleaning up the current result. What happens is that when a result is not cleaned up and then you make another query, then the first result set is not freed, but it is left dangling, with a reference to the connection: https://github.com/r-dbi/odbc/blob/a0ba73c72ca8f4cf33181fead7644b9b90aa2d4c/src/odbc_connection.cpp#L19 We test that the first result is invalidated in DBItest, here: https://github.com/r-dbi/DBItest/blob/2c29217bdd0b3314e6ec65216d99a3bf83a63464/R/spec-result-send-query.R#L92 So after that test there is still a result object, until the garbage collector runs next. If the garbage collector happens to run when there is another active result for the same connection, we remove that result from the connection, even though it is not the result we are finalizing. The workaround in this PR check that we are finalizing the active result in the destructor. A better solution would be to finalize the old result when a new one is set, but that seemed more difficult with the current code base.
* Update to testthat 3e * Eliminate some expect_is() calls * fixup tests * SQL Server: Index local temp tables (r-dbi#600) Update handling ( listing, writing ) of local temp tables. --------- Co-authored-by: Hadley Wickham <[email protected]> * SQL Server: Handle temporary flag in sqlCreateTable (r-dbi#601) * SQL Server: Handle temporary flag in sqlCreateTable * code-review: better warning + testthat usage * code-review: simplify sql server specific method * code-review: Add missing _snaps * Update news --------- Co-authored-by: detule <[email protected]>
detule
force-pushed
the
fixup/spark_schemas
branch
from
1f6bbac to
3c8f82e
Compare
detule
force-pushed
the
fixup/spark_schemas
branch
from
3c8f82e to
2c44151
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.