forked from r-dbi/odbc
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/interruptible execution #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
detule
wants to merge
59
commits into
main
Choose a base branch
from
feature/interruptible_execution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Supress arrow tests * Teach `id_field()` to work with unnamed Ids and test it * Update test because `dbUnquoteIdentifier` no longer names output * Skip test for SQL server that's skipped by all other backends
* databricks: schema enumeration: reasonable fallback Use databricks specific method only if catalog argument is non-null. * Update R/driver-spark.R Co-authored-by: Hadley Wickham <[email protected]> --------- Co-authored-by: Hadley Wickham <[email protected]>
* oracle: tables: do not escape when using exact query * code-review: tests and news --------- Co-authored-by: Hadley Wickham <[email protected]>
* fixup: merge resolution * fixup: oracle tests
* Use inline R code to speed up build process * Update to roxygen2 7.3.0
* Add `test_con()` helper and move individual database tests into own blocks * Add `local_table()` helper Fixes r-dbi#634
* teradata: Handle exact when looking through temp tables * code-review
Thanks @krlmlr --------- Co-authored-by: Hadley Wickham <[email protected]>
--------- Co-authored-by: Simon P. Couch <[email protected]>
…odbcConnectionIcon()` (r-dbi#750)
Add news bullet accidentally dropped in r-dbi#691
Don't load odbc (Fixes r-dbi#739), remove the headings, and put the database info in a details block.
* need to convert the column names to UTF-8 * throw correctly encoded error message when it contains nanodbc error or sql * add docs on the encoding of database and driver * offload work to output_encoder --------- Co-authored-by: shrektan <[email protected]> Co-authored-by: Hadley Wickham <[email protected]> Co-authored-by: Simon P. Couch <[email protected]>
* snowflake: improve performance on write * snowflake: columns: pass ellipsis * snowflake: Allow back-ends to optimize dbExistsTable and do so for snowflake * docs, news: update * docs: fixup * code-review: doc fixup * code-review: syntax cleanup * code-review: refactor * code-review: cleanup roxygen tags * code-review: moar cleanup roxygen tags * dbListFields: Implement for Id, SQL * code-review: update method signature
* connections-pane: infer hierarchy more efficienty * Update R/connection-pane.R Co-authored-by: Simon P. Couch <[email protected]> * Update R/connection-pane.R Co-authored-by: Simon P. Couch <[email protected]> * code-review: sub SQL_OWNER_USAGE for SQL_SCHEMA_USAGE --------- Co-authored-by: Simon P. Couch <[email protected]>
* connections-pane: handle postgres materialized views * fixup * Update R/connection-pane.R Co-authored-by: Simon P. Couch <[email protected]> * code-review: style * code-review: simplify * Update R/connection-pane.R Co-authored-by: Simon P. Couch <[email protected]> * Update R/connection-pane.R Co-authored-by: Simon P. Couch <[email protected]> --------- Co-authored-by: Simon P. Couch <[email protected]>
* rename `has_odbc()` to `has_unixodbc()` * add `is_macos()` helper * automatically configure spark on apple * integrate `configure_spark()` into `databricks()` * add NEWS entry * tell the user to install rather than doing so automatically * check if spark config is writeable before writing --------- Co-authored-by: Hadley Wickham <[email protected]>
* run `usethis::use_standalone("r-lib/rlang", "types-check")`
* check `dbConnect()` arguments
* check `dbList*()` arguments
* check read/write function arguments
* test custom error messages
* don't `allow_na`
Co-authored-by: Hadley Wickham <[email protected]>
* transition `stop()` -> `cli_abort()` * transition from `stopifnot()`
This reverts commit e0e91b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.