Fix selective retranslation when glossary aliases change#16
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When a chunk already matched a canonical glossary term, adding a new alias for that same term did not trigger selective retranslation. A concrete case is a chunk containing both
TaiandTaig: after recording state with onlyTai, addingTaigas an alias left the selected term ID list unchanged and the term hash unchanged, sorun_state planincorrectly marked the stale output as unchanged. This can silently leave untranslated or inconsistent alias usage in final book outputs.Root cause
scripts/glossary.py::term_hashonly includedsource,target, andcategory, whilerun_state.planrelies on selected term hashes to detect prompt-affecting glossary changes for already-selected terms. Alias changes affect both matching and the term table injected into translation prompts, but were omitted from the hash.Fix
Include sorted aliases in the structured term hash payload, so alias additions/removals trigger retranslation without treating alias reorderings as semantic changes.
Validation
python3 -m unittest tests.test_glossary.HashTests tests.test_run_state.RunStateTests -v— 16 tests passedpython3 -m unittest discover -s tests -p 'test_*.py' -v— 208 tests passed, 3 skippedpython3 -m compileall scripts tests— passedTaignow returnstranslation_chunk_ids: ["chunk0001"]with reasonglossary_term_hash_changed.