Fix merge validation for blank translated chunks#18
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
merge_markdown_files()then stripped that chunk to empty content and skipped it, allowingoutput.mdand final book artifacts to be generated with missing pages/chapters.Root cause
.strip()instead of failing.run_statecould record blank/truncated outputs as usable state.Fix
run_state.Validation
output_chunk0002.mdproducedmerge_ok=Trueand anoutput.mdmissing chunk 2.ERROR: Blank outputand does not createoutput.md.python3 -m unittest tests.test_merge_and_build.MergeMarkdownValidationTests tests.test_run_state.RunStateTests -vpython3 -m unittest discover -s tests -p 'test_*.py' -v(210 tests, 3 skipped)python3 -m compileall scripts testsstandard-alice.epub, copied chunks as mock translations, merged and built HTML/DOCX/PDF successfully. EPUB still fails due to the documented Ubuntu Calibre 7.6.0 packaging bug.