Fix stale glossary adoption for untracked outputs#20
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Untracked existing output chunks could be recorded into
run_state.jsoneven when the current glossary would inject terms into that chunk. If a user editedglossary.jsonbefore the first run-state record existed, stale translations could be treated as current and merged into final artifacts without retranslation.Root cause
run_state.plan()marked all valid untracked outputs asrecordby default unless--retranslate-untrackedwas passed. Glossary term selection/hash checks only ran after a chunk already had a run-state record.Fix
Validation
python3 -m unittest tests.test_run_state -vpython3 -m unittest discover -s tests -p 'test_*.py' -v(206 tests, 3 skipped)python3 -m compileall scripts testsTai -> 泰;scripts/run_state.py plannow returnstranslation_chunk_ids: ["chunk0001"]for the glossary-sensitive chunk and only record-only adopts the chunk with no glossary hit.