-
Notifications
You must be signed in to change notification settings - Fork 0
feat(site): 콘텐츠 탐색과 읽기 경험 개선 #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4772a19
feat(home): 콘텐츠 탐색 표면 정리
dev-wooyeon ea6b371
feat(typography): 콘텐츠 중심 타입 스케일 적용
dev-wooyeon 29ba7d2
fix(content): 새 글 공개 기본값 차단
dev-wooyeon 9416968
feat(home): 블로그 정체성과 추천 경로 추가
dev-wooyeon a213ae2
fix(content): 공개 글 신뢰 기준 재정비
dev-wooyeon 34d82f0
fix(article): 실제 스크롤 기준으로 읽기 UX 수정
dev-wooyeon a2cbd5a
fix(site): 탐색 복구 경로와 연락처 정합성 수정
dev-wooyeon 9379593
fix(home): 최근 30일 인기 조회 집계 적용
dev-wooyeon 5c4bcaf
fix(seo): OG 이미지 폰트 의존성 안정화
dev-wooyeon 7d9f42d
perf(font): TossFace 선로딩 제거
dev-wooyeon c483086
perf(mdx): 시각화 청크를 글 단위로 격리
dev-wooyeon 65b5280
perf(theme): 전환 애니메이션 렌더 비용 축소
dev-wooyeon 9d7c0a9
ci(quality): 배포 품질 gate 자동화
dev-wooyeon bbd569c
perf(shell): 클라이언트 글 payload 축소
dev-wooyeon d14b986
docs(adr): 인터페이스 관찰 정본 참조
dev-wooyeon 1e1c5a5
style(home): 불필요한 소개 문구 제거
dev-wooyeon cd079ab
refactor(home): 홈을 단일 피드 구조로 단순화
dev-wooyeon d0772db
refactor(home): 최신순 단일 피드로 단순화
dev-wooyeon 63281f4
fix(seo): OG 이미지 함수 용량 제한 해소
dev-wooyeon 76bce58
fix(seo): Vercel OG 폰트 경로 보정
dev-wooyeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: Quality | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| concurrency: | ||
| group: quality-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| validate: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Install Chromium | ||
| run: npx playwright install --with-deps chromium | ||
|
|
||
| - name: Run repository quality gate | ||
| run: npm run test:ci | ||
|
|
||
| - name: Upload browser failures | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: playwright-report | ||
| path: | | ||
| playwright-report | ||
| .cache/test-results | ||
| if-no-files-found: ignore | ||
| retention-days: 7 | ||
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // @vitest-environment node | ||
|
|
||
| import { describe, expect, it } from 'vitest'; | ||
| import { NextRequest } from 'next/server'; | ||
|
|
||
| const PNG_SIGNATURE = [137, 80, 78, 71, 13, 10, 26, 10]; | ||
|
|
||
| describe('GET /api/og', () => { | ||
| it('returns a non-empty PNG from the Node.js runtime', async () => { | ||
| const { GET, runtime } = await import('./route'); | ||
| const response = await GET( | ||
| new NextRequest( | ||
| 'https://ark-log.vercel.app/api/og?title=%ED%95%9C%EA%B8%80%20OG%20%EC%9D%B4%EB%AF%B8%EC%A7%80&tags=Next.js,Ark' | ||
| ) | ||
| ); | ||
| const bytes = new Uint8Array(await response.arrayBuffer()); | ||
|
|
||
| expect(runtime).toBe('nodejs'); | ||
| expect(response.status).toBe(200); | ||
| expect(response.headers.get('content-type')).toBe('image/png'); | ||
| expect(bytes.byteLength).toBeGreaterThan(10_000); | ||
| expect(Array.from(bytes.slice(0, PNG_SIGNATURE.length))).toEqual( | ||
| PNG_SIGNATURE | ||
| ); | ||
| }, 30_000); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import fs from 'node:fs'; | ||
| import path from 'node:path'; | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| const layoutPath = path.resolve(process.cwd(), 'app/layout.tsx'); | ||
| const layoutContent = fs.readFileSync(layoutPath, 'utf8'); | ||
| const tossfacePath = path.resolve(process.cwd(), 'styles/tossface.css'); | ||
| const tossfaceContent = fs.readFileSync(tossfacePath, 'utf8'); | ||
|
|
||
| describe('root layout font loading', () => { | ||
| it('preloads the primary text font without eagerly loading Tossface', () => { | ||
| expect(layoutContent).toContain('href="/fonts/PretendardVariable.woff2"'); | ||
| expect(layoutContent).not.toContain('href="/fonts/TossFaceFontWeb.otf"'); | ||
| }); | ||
|
|
||
| it('passes a public client DTO instead of full editorial metadata', () => { | ||
| expect(layoutContent).toContain('selectClientPosts(getSortedFeedData())'); | ||
| expect(layoutContent).toContain('<AppProviders posts={posts}>'); | ||
| }); | ||
|
|
||
| it('keeps Tossface demand-driven for matching emoji glyphs', () => { | ||
| expect(layoutContent).toContain("import '@/styles/tossface.css';"); | ||
| expect(tossfaceContent).toContain("font-family: 'Tossface Safe';"); | ||
| expect(tossfaceContent).toContain('unicode-range:'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { render, screen } from '@testing-library/react'; | ||
| import { describe, expect, it } from 'vitest'; | ||
| import NotFound from './not-found'; | ||
|
|
||
| describe('NotFound', () => { | ||
| it('offers a Korean recovery path to the home page', () => { | ||
| render(<NotFound />); | ||
|
|
||
| expect( | ||
| screen.getByRole('heading', { name: '페이지를 찾을 수 없어요' }) | ||
| ).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByRole('link', { name: '홈으로 돌아가기' }) | ||
| ).toHaveAttribute('href', '/'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import Link from 'next/link'; | ||
| import { Container } from '@/ui/layout'; | ||
|
|
||
| export default function NotFound() { | ||
| return ( | ||
| <main> | ||
| <Container size="sm" className="py-24 text-center md:py-32"> | ||
| <p className="text-meta font-semibold text-[var(--color-toss-blue)]"> | ||
| 404 | ||
| </p> | ||
| <h1 className="mt-3 text-2xl font-bold tracking-tight text-[var(--color-text-primary)] sm:text-3xl"> | ||
| 페이지를 찾을 수 없어요 | ||
| </h1> | ||
| <p className="mx-auto mt-4 max-w-xl text-reading leading-relaxed text-[var(--color-text-secondary)]"> | ||
| 주소가 바뀌었거나 글이 아직 공개되지 않았습니다. 홈에서 다른 기록을 | ||
| 살펴보세요. | ||
| </p> | ||
| <Link | ||
| href="/" | ||
| className="mt-8 inline-flex min-h-11 items-center justify-center rounded-[var(--radius-action)] bg-[var(--color-toss-blue)] px-5 text-sm font-semibold text-white transition-colors hover:bg-[var(--color-toss-blue-dark)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-toss-blue)] focus-visible:ring-offset-2 focus-visible:ring-offset-[var(--color-bg-primary)]" | ||
| > | ||
| 홈으로 돌아가기 | ||
| </Link> | ||
| </Container> | ||
| </main> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this checkout the long-lived branch is
mainand there is nomasterbranch, so thispush.branchesfilter prevents the new Quality workflow from running on merges or direct pushes to the actual release branch. The workflow still runs for PRs, but the post-merge/release quality gate is skipped; point this atmainor include both branch names.Useful? React with 👍 / 👎.