Skip to content

refactor(ui): accent token과 활성 탐색 상태 정리 - #120

Merged
dev-wooyeon merged 3 commits into
mainfrom
codex/active-navigation-accent
Jul 24, 2026
Merged

refactor(ui): accent token과 활성 탐색 상태 정리#120
dev-wooyeon merged 3 commits into
mainfrom
codex/active-navigation-accent

Conversation

@dev-wooyeon

@dev-wooyeon dev-wooyeon commented Jul 24, 2026

Copy link
Copy Markdown
Owner

변경 내용

  • 활성 primary link를 font-semibold로 구분
  • toss-blue 계열 token을 semantic accent token으로 정리
  • 관련 unit/E2E 테스트 selector 갱신

의도

  • 색상만 의존하지 않는 활성 탐색 상태 제공
  • 디자인 의미와 코드 token 이름 일치

영향 범위

  • AppShell navigation
  • 공통 accent color 참조
  • 버튼, 콘텐츠 링크, reading progress, TOC

검증

  • 관련 Vitest 33개
  • ESLint
  • CSS syntax check
  • git diff --check
  • 데스크톱/모바일 screenshot 비교

체크리스트

  • 작업 단위 브랜치 codex/에서 진행함
  • 커밋 메시지 규칙 준수
  • 관련 이슈/PR 링크 연결

@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ark Ready Ready Preview, Comment Jul 24, 2026 4:53am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d82b8e4c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread styles/globals.css
Comment on lines +160 to +161
.ark-site-primary-link[aria-current='page'] {
font-weight: var(--font-semibold);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve active nav weight through tablet overrides

At 640–1199px, app/layout.tsx imports styles/viewport/tablet.css after globals.css, and that later stylesheet resets .ark-site-primary-link to font-weight: var(--font-medium) with equal specificity. Since the active rule is defined only here, the new non-color aria-current state disappears on tablet widths; add an active override in the later viewport stylesheet or adjust ordering/specificity so active navigation links stay semibold across viewports.

AGENTS.md reference: AGENTS.md:L93-L95

Useful? React with 👍 / 👎.

@dev-wooyeon
dev-wooyeon merged commit b97707d into main Jul 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant