feat(blog): 글 읽기 레이아웃 개선 - #124
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
7f3f6ec to
a79f661
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a79f661fe0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ( | ||
| <nav className="ark-article-toc" aria-label="이 글의 목차"> |
There was a problem hiding this comment.
Record the inline TOC decision in an ADR
Replacing the fixed body portal with an in-flow TOC chooses between two implementations with material visibility, scrolling, and responsive-layout tradeoffs, and it also revises the reading layout previously covered by ADR 0051. This commit changes the decision without adding a numbered successor ADR or updating the ADR index; document the alternatives and consequences before merging.
AGENTS.md reference: AGENTS.md:L26-L35
Useful? React with 👍 / 👎.
| .ark-site-grid[data-page-layout='content'] .ark-article-container { | ||
| margin-right: 0; | ||
| margin-left: 0; |
There was a problem hiding this comment.
Keep the comments aligned with the article
On desktop widths where the content grid column exceeds the container's 800px maximum (including the configured 1440px desktop viewport), these overrides left-align only .ark-article-container, while the comments at BlogPostPage.tsx:178 remain in a centered Container size="md". The comments therefore begin roughly half the surplus column width to the right of the article; apply the same alignment policy to both sections or retain centering for both.
AGENTS.md reference: AGENTS.md:L93-L95
Useful? React with 👍 / 👎.
변경 내용
text-base에서text-sm으로 축소globals.css의 semantic class로 작성의도
글 내부에서 목차와 본문을 자연스럽게 함께 탐색할 수 있도록 읽기 흐름을 개선하고, 짧은 글에는 불필요한 목차가 표시되지 않도록 했습니다.
영향 범위
콘텐츠 페이지의 데스크톱 탐색 레이아웃, 인라인 목차, 인라인 코드 색상, 좌측 하단 외부 링크 크기에 영향을 줍니다.
검증
npm run test:unit -- blog/ui/components/TableOfContents.test.tsx styles/globals.test.ts styles/tokens.test.ts— 24 tests passednpm run lintnpm run lint:css:syntaxnpm run build체크리스트
codex/<task>)에서 진행함<type>: <한국어 설명>) 준수참고: 말하기 에세이 URL의 404는 기존
visibility: private설정과 관련된 별도 이슈이며, 최신main의 public 전환 및 URL percent-decoding 수정이 이번 PR의 기준에 반영되어 있습니다.