refactor(infra): Agentation 흐름과 시리즈 카드 정리 - #82
Conversation
개발 환경에서 Agentation overlay를 same-origin 프록시로 연결했어요. autorun webhook이 annotation 메타데이터를 프롬프트에 반영하고 stale 실행을 정리하도록 개선했어요. 로컬 개발 가이드도 현재 동작에 맞게 업데이트했어요.
시리즈 제목 앞의 중복 배지를 제거하고 에피소드 링크 여백을 정리했어요. 변경된 카드 구조를 검증하는 컴포넌트 테스트를 추가했어요.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dev-wooyeon
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 385e5862de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (isRunning && (isExpired || isIdle)) { | ||
| try { | ||
| process.kill(lock.pid, 'SIGTERM'); | ||
| } catch {} |
There was a problem hiding this comment.
When a lock is considered expired/idle, this code now unconditionally calls process.kill(lock.pid, 'SIGTERM') based only on the PID stored in .agentation/autorun.lock.json. If that lock survives long enough for PID reuse (e.g., after a crash/restart), a later webhook can terminate an unrelated local process that happens to have the same PID, which is a regression from the previous behavior that never killed running PIDs.
Useful? React with 👍 / 👎.
|
|
||
| const isRunning = isPidRunning(lock.pid); | ||
| const isExpired = getLockAgeMs(lock) > AUTORUN_MAX_AGE_MS; | ||
| const isIdle = getAutorunIdleMs() > AUTORUN_IDLE_TIMEOUT_MS; |
There was a problem hiding this comment.
Idle detection is based on autorun.log mtime, but starting a new child with openSync(..., 'a') does not update mtime until the process writes output. If another webhook arrives before the first log write, isIdle can be true immediately because the file still has an old timestamp from a previous run, causing a healthy fresh autorun to be killed and restarted.
Useful? React with 👍 / 👎.
* refactor(agentation): same-origin sync 흐름 정리 개발 환경에서 Agentation overlay를 same-origin 프록시로 연결했어요. autorun webhook이 annotation 메타데이터를 프롬프트에 반영하고 stale 실행을 정리하도록 개선했어요. 로컬 개발 가이드도 현재 동작에 맞게 업데이트했어요. * refactor(blog): 시리즈 허브 카드 구조 정리 시리즈 제목 앞의 중복 배지를 제거하고 에피소드 링크 여백을 정리했어요. 변경된 카드 구조를 검증하는 컴포넌트 테스트를 추가했어요.
1 participant
Summary
Commits
Testing
Notes