docs(blog): 블로그 문체와 메타 카피 정리 - #84
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9d3462e08
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }); | ||
| } | ||
|
|
||
| const child = runAutorunCommand(payload); |
There was a problem hiding this comment.
Two webhook requests arriving at nearly the same time can both pass the readLockFile() check and both execute runAutorunCommand(...) because the lock file is only written after spawning; this defeats the single-run guard and can launch overlapping codex runs that race on the same repo. This is most visible under bursty annotation.add events in development, and it should be fixed by creating the lock with an exclusive operation before process spawn (or using a mutex) so only one request can proceed.
Useful? React with 👍 / 👎.
| }) { | ||
| const { seriesId } = await params; | ||
|
|
||
| return <EngineeringSeriesPage seriesId={decodeURIComponent(seriesId)} />; |
There was a problem hiding this comment.
Dynamic route params are already decoded by Next.js, so decoding seriesId again can throw URIError for valid encoded inputs that resolve to % (for example /engineering/series/%25), turning what should be a normal not-found path into a 500 response. Passing the param through without a second decodeURIComponent avoids this crash path.
Useful? React with 👍 / 👎.
e9d3462 to
d920b88
Compare
비시리즈 Engineering/Life 글의 본문을 낮은 톤 해요체로 정리했어요. 도입과 전환, 정리 문장을 다시 구성해서 첫 화면의 문제 제기와 읽기 보상이 보이도록 맞췄어요.
Engineering/Life 목록 소개와 포스트 메타 카피를 낮은 톤 해요체로 맞췄어요. 카드 설명 원천인 meta.json과 읽기 시간, 조회수, 목차 문구를 함께 정리하고 관련 테스트도 갱신했어요.
d920b88 to
b331884
Compare
…resh docs(blog): 블로그 문체와 메타 카피 정리
1 participant
변경 내용
의도
영향 범위
검증
npm run buildnpx vitest run src/features/blog/ui/components/ViewCounter.test.tsx src/features/blog/ui/components/PostCard.test.tsx src/features/blog/ui/pages/EngineeringPage.test.tsx src/features/blog/ui/pages/LifePage.test.tsx src/features/blog/ui/pages/EngineeringPageClient.test.tsx체크리스트
codex/<task>)에서 진행함<type>: <한국어 설명>) 준수