Skip to content

feat(home): Linear형 앱 셸 레이아웃 전환 - #91

Merged
dev-wooyeon merged 2 commits into
masterfrom
codex/home-feed-layout-review
Apr 21, 2026
Merged

feat(home): Linear형 앱 셸 레이아웃 전환#91
dev-wooyeon merged 2 commits into
masterfrom
codex/home-feed-layout-review

Conversation

@dev-wooyeon

Copy link
Copy Markdown
Owner

Summary

  • 전역 좌측 레일과 컨텍스트 패널을 도입해 홈, 리스트, 상세 페이지의 탐색 경험을 통일
  • 홈을 피드 중심 구조로 재구성하고 검색/정렬/카테고리 흐름 정리
  • 검색 바와 다크 모드 토글의 가시성을 개선하고 홈 프로필 카드는 제거

Testing

  • npm run test:unit -- src/features/home/model/home-feed.test.ts src/features/home/ui/pages/HomePage.test.tsx src/features/blog/ui/components/PostCard.test.tsx
  • npm run lint -- src/shared/layout/AppShell/AppShell.tsx src/shared/ui/ThemeToggle.tsx src/features/home/ui/pages/HomePage.tsx src/features/home/ui/pages/HomePageClient.tsx src/features/blog/ui/pages/BlogListPage.tsx src/features/blog/ui/pages/BlogPostPage.tsx src/features/blog/ui/pages/EngineeringPage.tsx src/features/blog/ui/pages/EngineeringSeriesPage.tsx src/features/blog/ui/pages/LifePage.tsx src/features/blog/ui/pages/SeriesPage.tsx src/features/resume/ui/pages/ResumePage.tsx src/app/layout.tsx src/features/blog/ui/components/PostCard/PostCard.tsx src/features/blog/ui/components/PostCard.test.tsx
  • npm run build

전역 좌측 레일과 컨텍스트 패널을 도입해서 홈, 리스트, 상세 페이지의 탐색 경험을 통일했어요.

홈 피드를 검색과 정렬 중심 구조로 재구성하고 테마 토글과 검색 가시성도 함께 정리했어요.
@vercel

vercel Bot commented Apr 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
eunu-log Ready Ready Preview, Comment Apr 20, 2026 8:10am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 200df1e03f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

});
}}
className="relative p-2 rounded-lg hover:bg-[var(--color-grey-100)] transition-colors focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-toss-blue)]"
className="relative inline-flex h-11 w-[88px] items-center rounded-full border border-[var(--color-grey-200)] bg-[var(--color-grey-50)] px-2 focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-toss-blue)]"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove arbitrary Tailwind width utility

The repository rule in /workspace/eunu-log/AGENTS.md explicitly says to never use arbitrary Tailwind values, but this change introduces w-[88px] (and similar bracketed values elsewhere in the new shell UI). Hard-coded bracket values bypass shared tokens/utilities, which makes future design-token updates inconsistent and increases maintenance drift across components.

Useful? React with 👍 / 👎.

Comment on lines +285 to +287
type="button"
onClick={() => query.toggle()}
className="inline-flex h-11 w-full items-center gap-3 rounded-full border border-[var(--color-grey-200)] bg-[var(--color-grey-50)] px-4 text-sm text-[var(--color-grey-500)] transition-colors hover:border-[var(--color-grey-300)] hover:text-[var(--color-grey-900)]"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore search-open click event tracking

The new global search trigger no longer emits the click analytics event when users open the command palette (onClick only toggles KBar). Since this commit also removes Header usage across pages, the previous AnalyticsEvents.click instrumentation from Header is effectively gone, so search-button engagement metrics will drop to zero and distort experiment/product analytics.

Useful? React with 👍 / 👎.

@dev-wooyeon
dev-wooyeon merged commit 6acdcac into master Apr 21, 2026
3 checks passed
@dev-wooyeon
dev-wooyeon deleted the codex/home-feed-layout-review branch June 15, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant