fix(search): 슬래시 단축키 토글 중복 수정 - #98
Merged
Merged
Conversation
모바일과 데스크톱 검색 버튼이 각각 전역 keydown listener를 등록해 / 입력 시 검색창이 즉시 닫히던 문제를 수정합니다. 단축키 처리를 AppShell 단일 listener로 이동하고 검색 입력 aria-label과 회귀 테스트를 추가합니다.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
/검색 단축키 리스너를AppShell단일 위치로 이동했습니다.aria-label을 추가했습니다./입력 후 검색창이 열린 상태를 유지하는 Playwright 회귀 테스트를 추가했습니다.의도
/입력 시 검색창이 바로 닫히는 문제를 수정합니다.영향 범위
검증
npx playwright test tests/e2e/regression/search-shortcut.spec.tsnpm run buildnpm test체크리스트
codex/<task>)에서 진행함<type>: <한국어 설명>) 준수