Fix undefined reference error when using alternative drawing sheets #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a module that uses an alternative sheet for some of my drawings. but I still want to have Advanced Drawing Module available for others. I noticed that when I try to submit changes from my sheet, I get null reference errors. I've previously noticed this when trying to use ADT with https://github.com/mordachai/investigation-board, for the same reason.
Turns out the fix is simple - there's one place with a jQuery check into the sheet
formDataresponse. Adding an optional chaining operator seems to fix it immediately.PR attached for your consideration!