-
Notifications
You must be signed in to change notification settings - Fork 8
1.10 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
1.10 #147
Conversation
* Use Kdialog for AstroArch Tweak Tool * Added notifications for astroarch-tweak-tool * Tip to no longer ask password with sudo * update .zshrc with OS history and updates * Convert versions to correct numeric format * Bootstrap process for building AstroArch from existing AstroArch * Bootstrap process for building AstroArch from existing AstroArch part2 * Bootstrap process for building AstroArch from existing AstroArch part3 * Bootstrap process for building AstroArch from existing AstroArch part4 * Bootstrap process for building AstroArch from existing AstroArch update * Bootstrap process for building AstroArch from existing AstroArch update2 * Bootstrap process for building AstroArch from existing AstroArch update3 * Bootstrap process for building AstroArch from existing AstroArch update4 * Bootstrap process for building AstroArch from existing AstroArch update5 * Bootstrap process for building AstroArch from existing AstroArch update6 * Add astroarch-onboarding * Add astroarch-onboarding update * update build * update onboarding sh * update vncserver service * update script * update script build * update script clean * update script build * update script and file for build * update script * update script, add file cmdline.txt * update script zshrc * update script * Add Script 1.10-sc74.sh * update script * update folder script for sc74 * update script for 1.10-sc74.sh * update 1.10-sc74.sh
check=$(pacman -Q | grep 'bluez|bluez-utils|bluez-hid2hci|bluedevil') | ||
if [[ $check -eq 0 ]]; then | ||
check=$(pacman -Q | grep -E -c 'bluez|bluez-utils|bluez-hid2hci|bluedevil') | ||
if [[ $check -lt 6 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sc74 I need an explanation here as I don't understand where 6 comes from, can you drop a # comment please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a working Bluetooth installation, the return value of grep -E -c 'bluez|bluez-utils|bluez-hid2hci|bluedevil') is 6. The idea was to check this and, if not, to redo the installation
fi | ||
|
||
# Recovering the old version (although it will no longer be used for testing) | ||
if [ -f "/home/astronaut/.astroarch/configs/.astroarch.version" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sc74 I need an explanation here as I don't understand how this file may be missing on the FS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not missing, but it is a check in case of possible deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you delete this, the git history becomes dirty and update-astroarch is either failing or pulling it back, don't think we need this guard rail here, but if you feel better having it in place, we can leave it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's up to you, anyway a correction can be added quickly later
echo "Minimum version required : $MIN_VERSION ($MIN_NUM)" | ||
|
||
# Update Scripts Walkthrough | ||
for script in /home/astronaut/.astroarch/scripts/1.*.sh; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sc74 does this behave as we expect mantaining the order of the numbers or does it walks the scripts folder randomly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This produces an increment normally from smallest to largest number
If for any reason someone will change astronaut password, the scripts will just break as the pass is hardcoded and it is in a file that comes from github.
No description provided.