Enhancement for offline validation and Support for SUSE and REDHAT as management server#11
Merged
devanshjainms merged 16 commits intofeature/offline-validationfrom Jul 3, 2025
Merged
Conversation
… command line options
…le and ensure consistent os_family assignment
… logging; add utils.sh for shared functions. Update ha-config-offline.yml to change CIB file path to system_output.
… HA functional tests
…ks and tests for improved structure and functionality
…ation validation tasks
…packages in setup script
…ng for package facts collection in HA configuration
0e3e230
into
feature/offline-validation
6 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors to the SAP automation scripts, focusing on modularization, offline testing capabilities, and improved error handling. Key changes include the addition of a
utils.shscript for reusable utility functions, support for offline testing insap_automation_qa.sh, and updates to package installation logic insetup.sh.Enhancements to
sap_automation_qa.sh:Offline Testing Support:
--offlineflag to run test cases using pre-collected Cluster Information Base (CIB) data. Includes validation to ensure CIB files are present before proceeding. [1] [2]get_playbook_nameto return offline-specific playbooks based on theOFFLINE_MODEflag.run_ansible_playbookto skip SSH authentication setup in offline mode.Improved Portability and Error Handling:
Modularization and Code Reuse:
utils.sh:Updates to
setup.sh:utils.shfunctions, including distribution-specific mappings for package names.Code Refinements in
src/module_utils/sap_automation_qa.py:parse_xml_outputmethod to always return anET.Element, removing theOptionaltype hint.These changes collectively improve the modularity, maintainability, and functionality of the SAP automation scripts, making them more robust and user-friendly.