feat(execution): Implement execution layer for test management#14
feat(execution): Implement execution layer for test management#14devanshjainms merged 1 commit intoschedulerfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,36 @@ | |||
| # Copyright (c) Microsoft Corporation. | |||
Check failure
Code scanning / Trivy
Image user should not be 'root' High
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bd46c174b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| healthcheck: | ||
| test: ["CMD", "curl", "-f", "http://localhost:8000/health"] |
There was a problem hiding this comment.
The compose healthcheck hits /health, but the API only registers /healthz in src/api/routes/health.py. With curl -f, this will return 404 and mark the container unhealthy even when the service is up, causing false negatives and potential restarts in Docker Compose deployments.
Useful? React with 👍 / 👎.
| - name: get_hana_clone_resource_id | ||
| SUSE: "cibadmin --query --xpath \"//primitive[@type='SAPHana']\" --node-path | grep -oP \"master\\[@id='\\K[^']+\"" | ||
| SUSE: "cibadmin --query --xpath \"//primitive[@type='SAPHana']\" --node-path | grep -oP \"primtive\\[@id='\\K[^']+\"" |
There was a problem hiding this comment.
The SUSE command for get_hana_clone_resource_id uses primtive in the grep regex, which won’t match the primitive[@id=...] nodes. On SUSE systems this will yield an empty clone resource ID, breaking the HANA DB HA test flow that depends on it.
Useful? React with 👍 / 👎.
2 participants
No description provided.