-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(desktop-lite): make fluxbox optional #1058
base: main
Are you sure you want to change the base?
feat(desktop-lite): make fluxbox optional #1058
Conversation
The tests pass.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, left some minor comments.
Co-authored-by: Samruddhi Khandale <[email protected]>
Co-authored-by: Samruddhi Khandale <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@@ -197,7 +198,12 @@ else | |||
package_list="${package_list} tilix" | |||
fi | |||
|
|||
# Install X11, fluxbox and VS Code dependencies | |||
# If we want to install Fluxbox, then add it to the list of pacakges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# If we want to install Fluxbox, then add it to the list of pacakges | |
# If we want to install Fluxbox, then add it to the list of packages |
This PR implements the
installFluxbox
parameter that allows template administrators to install another windows manager or desktop environment if they wish to do so.#1030