-
Notifications
You must be signed in to change notification settings - Fork 445
fix(rust): remove rls and rust-analysis for Rust 1.87+ compatibility #1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Rust 1.87.0 and later have removed the long-deprecated RLS and rust-analysis components. This change updates the install script to only add rust-src, rustfmt, and clippy, preventing build errors during feature installation. See: rust-lang/rust#126856 https://blog.rust-lang.org/2022/07/01/RLS-deprecation/ https://github.com/rust-lang/rustup/blob/a92432fc8b6d5d4e56ebd08ca1c45b7b1294c1bd/doc/user-guide/src/concepts/components.md#previous-components Fixes: devcontainers#1361
Hey! I just added a couple more changes: liskin#1 Not 100% familiar with fork etiquette so I kinda just added it on to your fork. Thanks! |
Also, as a quick workaround for anyone facing a similar problem. Just pin rust to
Tip Read more about rustup profiles here |
Thank you @liskin and @NeoScript for your contributions. |
@microsoft-github-policy-service agree (although I wonder if it's really me who needs to agree, as this CLA nonsense started only after I've pulled @NeoScript's commits into my branch…) |
@microsoft-github-policy-service agree Hello! Sorry I've not seen any notifications around the service agree but just in case. |
Rust 1.87.0 and later have removed the long-deprecated RLS and rust-analysis components. This change updates the install script to only add rust-src, rustfmt, and clippy, preventing build errors during feature installation. See: rust-lang/rust#126856 https://blog.rust-lang.org/2022/07/01/RLS-deprecation/ https://github.com/rust-lang/rustup/blob/a92432fc8b6d5d4e56ebd08ca1c45b7b1294c1bd/doc/user-guide/src/concepts/components.md#previous-components
Fixes: #1361