Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ubuntu] - remove existing ubuntu user #1170

Merged
merged 29 commits into from
Sep 19, 2024
Merged

[base-ubuntu] - remove existing ubuntu user #1170

merged 29 commits into from
Sep 19, 2024

Conversation

gauravsaini04
Copy link
Contributor

@gauravsaini04 gauravsaini04 commented Aug 23, 2024 •
edited
Loading

Devcontainer Names

  • base-ubuntu

Description

  • This PR attemtps to make the following changes:
    • Removes the existing ubuntu user provided by the base-image for ubuntu-noble base image i.e. existing user blocking uid & gid 1000

Changelog

  • Changed the Dockerfile and wrote a test case for the devcontainer image

Checklist

  • Checked that applied changes work as expected

samruddhikhandale
samruddhikhandale requested changes Aug 23, 2024
View reviewed changes
@gauravsaini04
Copy link
Contributor Author 

https://github.com/devcontainers/images/actions/runs/10534973968/job/29193352531?pr=1170#step:3:2854

The failing tests would pass in the dev codespace env.

@gauravsaini04 gauravsaini04 mentioned this pull request Aug 27, 2024
Closed
samruddhikhandale
samruddhikhandale reviewed Aug 27, 2024
View reviewed changes
@gauravsaini04 gauravsaini04 marked this pull request as ready for review August 28, 2024 14:39
@gauravsaini04 gauravsaini04 requested a review from a team as a code owner August 28, 2024 14:39
@gauravsaini04 gauravsaini04 changed the title [base-ubuntu, dotnet] - remove existing ubuntu user [base-ubuntu] - remove existing ubuntu user Aug 30, 2024
@jmuchovej jmuchovej mentioned this pull request Sep 8, 2024
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 9, 2024
View reviewed changes
samruddhikhandale
samruddhikhandale requested changes Sep 18, 2024
View reviewed changes
@samruddhikhandale samruddhikhandale merged commit dcfef0d into devcontainers:main Sep 19, 2024
2 checks passed
@gauravsaini04 gauravsaini04 deleted the base-ubuntu_dotnet_del_existing_noble_usr branch September 20, 2024 03:45
@samruddhikhandale samruddhikhandale mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gauravsaini04 @samruddhikhandale