Improve logging consistency and fix typos in event IDs and messages across connectors.

Author: tsutomi

src/Deveel.Messaging.Connector.Abstractions/Messaging/ChannelConnectorBase.cs

@@ -272,7 +272,7 @@ protected async Task<ConnectorResult<bool>> RefreshAuthenticationAsync(Cancellat
 
 				if (authConfig == null)
 				{
-					Logger.LogAuthenticationConfigurationNotFound(_authenticationCredential.AuthenticationType);
+					Logger.LogAuthenticationConfigurationNotFoundForType(_authenticationCredential.AuthenticationType);
 					return await AuthenticateAsync(cancellationToken);
 				}
 

src/Deveel.Messaging.Connector.Abstractions/Messaging/ConnectorLoggerEventId.cs

@@ -4,15 +4,16 @@ internal static class ConnectorLoggerEventId
 {
     public const int StartingAuthentication = LoggerEventId.BaseId + 10;
     public const int NoAuthenticationConfigurationFound = LoggerEventId.BaseId + 11;
-    public const int UsingAuthenticationConfiguration = LoggerEventId.BaseId + 12;
-    public const int AuthenticationSuccessful = LoggerEventId.BaseId + 13;
-    public const int AuthenticationFailed = LoggerEventId.BaseId + 14;
-    public const int AuthenticationException = LoggerEventId.BaseId + 15;
-    public const int NoCredentialToRefresh = LoggerEventId.BaseId + 16;
-    public const int RefreshingAuthenticationCredential = LoggerEventId.BaseId + 17;
-    public const int AuthenticationCredentialRefreshed = LoggerEventId.BaseId + 18;
-    public const int AuthenticationCredentialRefreshFailed = LoggerEventId.BaseId + 19;
-    public const int AuthenticationCredentialRefreshException = LoggerEventId.BaseId + 20;
+    public const int NoAuthenticationConfigurationFoundForType = LoggerEventId.BaseId + 12;
+    public const int UsingAuthenticationConfiguration = LoggerEventId.BaseId + 13;
+    public const int AuthenticationSuccessful = LoggerEventId.BaseId + 14;
+    public const int AuthenticationFailed = LoggerEventId.BaseId + 15;
+    public const int AuthenticationException = LoggerEventId.BaseId + 16;
+    public const int NoCredentialToRefresh = LoggerEventId.BaseId + 17;
+    public const int RefreshingAuthenticationCredential = LoggerEventId.BaseId + 18;
+    public const int AuthenticationCredentialRefreshed = LoggerEventId.BaseId + 19;
+    public const int AuthenticationCredentialRefreshFailed = LoggerEventId.BaseId + 20;
+    public const int AuthenticationCredentialRefreshException = LoggerEventId.BaseId + 21;
 
     public const int CheckingHealth = LoggerEventId.BaseId + 25;
     public const int HealthCheckSuccessful = LoggerEventId.BaseId + 26;

src/Deveel.Messaging.Connector.Abstractions/Messaging/LoggerExtensions.cs

@@ -63,10 +63,10 @@ internal static partial class LoggerExtensions
         internal static partial void LogRefreshingAuthenticationCredential(this ILogger logger);
 
         [LoggerMessage(
-            EventId = ConnectorLoggerEventId.NoAuthenticationConfigurationFound,
+            EventId = ConnectorLoggerEventId.NoAuthenticationConfigurationFoundForType,
             Level = LogLevel.Warning,
-            Message = "Authentication configuration not found for credential type: {AuthenticationType}")]
-        internal static partial void LogAuthenticationConfigurationNotFound(this ILogger logger, AuthenticationType authenticationType);
+            Message = "Authentication configuration not found for credential type {AuthenticationType}")]
+        internal static partial void LogAuthenticationConfigurationNotFoundForType(this ILogger logger, AuthenticationType authenticationType);
 
         [LoggerMessage(
             EventId = ConnectorLoggerEventId.AuthenticationCredentialRefreshed,
@@ -144,8 +144,8 @@ internal static partial class LoggerExtensions
 
         [LoggerMessage(
             EventId = ConnectorLoggerEventId.StatusRead,
-            Level = LogLevel.Error,
-            Message = "Failed to read connector status")]
+            Level = LogLevel.Information,
+            Message = "Connector status read")]
         internal static partial void LogStatusRead(this ILogger logger);
 
         [LoggerMessage(
@@ -163,7 +163,7 @@ internal static partial class LoggerExtensions
         [LoggerMessage(
             EventId = ConnectorLoggerEventId.HealthCheckSuccessful,
             Level = LogLevel.Information,
-            Message = "Connector health check was succesful")]
+            Message = "Connector health check was successful")]
         public static partial void LogHealthCheckSuccessful(this ILogger logger);
 
         [LoggerMessage(

src/Deveel.Messaging.Connector.Firebase/Messaging/FirebasePushConnector.cs

@@ -63,8 +63,6 @@ public FirebasePushConnector(ConnectionSettings connectionSettings, IFirebaseSer
         /// <inheritdoc/>
         protected override async ValueTask InitializeConnectorAsync(CancellationToken cancellationToken)
         {
-            using var loggerScope = Logger.BeginScope("ProjectId={ProjectId}", new { ProjectId = _projectId });
-
             // Perform authentication first
             var result = await AuthenticateAsync(cancellationToken);
             if (!result.Successful)
@@ -82,6 +80,8 @@ protected override async ValueTask InitializeConnectorAsync(CancellationToken ca
                 throw new MessagingException(ConnectorErrorCodes.InitializationError, "ProjectId is required");
             }
 
+            using var loggerScope = Logger.BeginScope("ProjectId={ProjectId}", _projectId);
+
             // Get the service account key from the authenticated credential
             if (AuthenticationCredential?.AuthenticationType == AuthenticationType.Certificate)
             {

src/Deveel.Messaging.Connector.Telegram/Messaging/LoggerExtensions.cs

@@ -19,7 +19,7 @@ internal static partial class LoggerExtensions
 		public static partial void LogBotInitialized(this ILogger logger, string? botUsername, long botId);
 
         [LoggerMessage(
-            EventId = TelegramLoggerEventId.BotConnectionTestSuccessfull,
+            EventId = TelegramLoggerEventId.BotConnectionTestSuccessful,
             Level = LogLevel.Information,
             Message = "Bot connection test successful: @{BotUsername} ({BotId})")]
         public static partial void LogBotConnectionTestSuccessful(this ILogger logger, string? botUsername, long botId);
@@ -77,7 +77,7 @@ internal static partial class LoggerExtensions
 			Level = LogLevel.Warning,
 			Message = "Failed to remove webhook during shutdown")]
 		public static partial void LogWebhookRemovalFailed(this ILogger logger, Exception exception);
-        
+
 		[LoggerMessage(
 			EventId = 6002,
 			Level = LogLevel.Warning,

src/Deveel.Messaging.Connector.Telegram/Messaging/TelegramLoggerEventId.cs

@@ -6,5 +6,5 @@ public static class TelegramLoggerEventId
 
     public const int BotInitialized = BaseId + 1002;
 
-    public const int BotConnectionTestSuccessfull = BaseId + 2001;
+    public const int BotConnectionTestSuccessful = BaseId + 2001;
 }