Skip to content

Conversation

@ShashwatMDas
Copy link

Beside the toggle button, added dynamic text changing ability for dark and light mode

@welcome
Copy link

welcome bot commented Oct 2, 2020

Thanks for opening this pull request! Make sure you are following our contribution guidelines and the pull request is associated with an issue.

@shubhank-saxena
Copy link
Member

Thank you @ShashwatMDas for this PR. Could you attach the outcome screenshot after your changes?

@ShashwatMDas
Copy link
Author

Thank you @ShashwatMDas for this PR. Could you attach the outcome screenshot after your changes?

Yeah sure. @shubhank-saxena

Previous behavior,
Screenshot from 2020-10-02 22-59-48

Current behavior,

Screenshot from 2020-10-02 23-01-11

Screenshot from 2020-10-02 23-01-57

@SabhyaGrover
Copy link
Member

@ShashwatMDas can you retain the text of URL Shortner as well ?

@ShashwatMDas
Copy link
Author

Okay sure! Can you merge this PR and I'll create another one with the change?

@shubhank-saxena
Copy link
Member

@SabhyaGrover I had merged a PR which has fixed the text and the overall appearance of the navbar. So we can move ahead with this PR.
@ShashwatMDas this looks good to me. Just fix the merge conflicts and we are good to go 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants