Skip to content

fix: update types for url config parameters to be compatible with str #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Feb 28, 2025

⚠️ Checklist if your PR is changing anything else than documentation

  • Posted the link to a successful manually triggered deployment workflow (successful including the resources destruction)

successful deployment run

Merge request description

This updates the config to convert the urls to strings after validating the url with AnyHttpUrl.

Resolves #126

@hrodmn hrodmn changed the title update types for url config parameters to be compatible with str fix: update types for url config parameters to be compatible with str Feb 28, 2025
@hrodmn hrodmn marked this pull request as ready for review February 28, 2025 20:04
@hrodmn hrodmn requested a review from jjfrench February 28, 2025 20:04
@hrodmn hrodmn self-assigned this Feb 28, 2025
@hrodmn hrodmn requested a review from vincentsarago February 28, 2025 20:46
@hrodmn hrodmn removed the request for review from vincentsarago February 28, 2025 20:55
@hrodmn hrodmn merged commit cab4c0e into main Feb 28, 2025
6 checks passed
@hrodmn hrodmn deleted the fix/url-strings branch February 28, 2025 20:56
github-actions bot pushed a commit that referenced this pull request Feb 28, 2025
## [7.6.1](v7.6.0...v7.6.1) (2025-02-28)

### Bug Fixes

* update types for url config parameters to be compatible with str ([#127](#127)) ([cab4c0e](cab4c0e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pydantic v2 AnyHttpUrl not compatible with validator functions in the ingestor API
2 participants