-
Notifications
You must be signed in to change notification settings - Fork 4
feat: update versions for pgstac, stac-fastapi-pgstac, titiler-pgstac, and tipg #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
247580a
to
0f7e614
Compare
I opted to remove all of the custom |
555a243
to
671f442
Compare
I have deployed a less temporary stack with these changes: Everything seems to be working well with the default applications that are shipped with the tipg/titiler-pgstac/stac-fastapi-pgstac packages. Do these changes warrant a major version release? I think we might be due for v8.0 because of the breaking API changes that we are adding in the default titiler-pgstac and stac-fastapi-pgstac runtimes. I will see about updating the documentation to help users understand the default behavior and point towards examples of how to customize the applications. |
👍 |
I also manually created a deployment with
integration_tests/cdk/app.py
and verified that all of the services are working with these changes.Merge request description
Update versions for the core dependencies! Should this be a major version change since there are breaking changes in the APIs for stac-fastapi-pgstac (stac-fastapi>=0.5) and titiler-pgstac (from titiler>=0.19)?
Resolves #115
I don't love using
os.environ.update(...)
to set the postgres settings in the handlers, but that is the only way to load e.g.stac_fastapi.pgstac.app
since that module will load settings from the environment and fail if thePOSTGRES_*
variables are not set in the environment. We can load these settings in the newconfig
modules, but to use the custom settings we have to completely re-define the app module in this repo - I would much rather use the pre-definedapp
variables here to make long-term maintenance easier.@vincentsarago what do you think? We could refactor titiler-pgstac and stac-fastapi-pgstac a little bit so the application modules can be loaded even if those environment variables are present, then fail loudly on application startup if they are not configured.
One option would be to update the Lambda constructs with those
POSTGRES_*
environment variables set directly rather than settingPGSTAC_SECRET_ARN
. I know we used to do that in eoapi-devseed but maybe it's not ideal from a security standpoint.