Skip to content

feat: update versions for pgstac, stac-fastapi-pgstac, titiler-pgstac, and tipg #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 11, 2025

Conversation

hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Mar 3, 2025

⚠️ Checklist if your PR is changing anything else than documentation

I also manually created a deployment with integration_tests/cdk/app.py and verified that all of the services are working with these changes.

Merge request description

Update versions for the core dependencies! Should this be a major version change since there are breaking changes in the APIs for stac-fastapi-pgstac (stac-fastapi>=0.5) and titiler-pgstac (from titiler>=0.19)?

Resolves #115

I don't love using os.environ.update(...) to set the postgres settings in the handlers, but that is the only way to load e.g. stac_fastapi.pgstac.app since that module will load settings from the environment and fail if the POSTGRES_* variables are not set in the environment. We can load these settings in the new config modules, but to use the custom settings we have to completely re-define the app module in this repo - I would much rather use the pre-defined app variables here to make long-term maintenance easier.

@vincentsarago what do you think? We could refactor titiler-pgstac and stac-fastapi-pgstac a little bit so the application modules can be loaded even if those environment variables are present, then fail loudly on application startup if they are not configured.

One option would be to update the Lambda constructs with those POSTGRES_* environment variables set directly rather than setting PGSTAC_SECRET_ARN. I know we used to do that in eoapi-devseed but maybe it's not ideal from a security standpoint.

@hrodmn hrodmn force-pushed the feat/update-runtime-versions branch from 247580a to 0f7e614 Compare March 3, 2025 16:25
@hrodmn hrodmn changed the title feat: update versions for stac-fastapi-pgstac, titiler-pgstac, and tipg feat: update versions for pgstac, stac-fastapi-pgstac, titiler-pgstac, and tipg Mar 3, 2025
@hrodmn hrodmn marked this pull request as ready for review March 3, 2025 21:17
@hrodmn
Copy link
Contributor Author

hrodmn commented Mar 4, 2025

I opted to remove all of the custom app and config modules in favor of the default applications that get shipped with stac_fastapi.pgstac and titiler.pgstac. This simplifies the process of updating default versions in eoapi-cdk in the future and hopefully reduce confusion for users. You either get the default application that is shipped with titiler.pgstac==x.x.x or you can write a custom runtime.

@hrodmn hrodmn requested a review from vincentsarago March 4, 2025 12:41
@hrodmn hrodmn force-pushed the feat/update-runtime-versions branch from 555a243 to 671f442 Compare March 10, 2025 14:50
@hrodmn
Copy link
Contributor Author

hrodmn commented Mar 10, 2025

I have deployed a less temporary stack with these changes:
stac-fastapi-pgstac: https://mc8hmu6918.execute-api.us-east-1.amazonaws.com/
tipg: https://jnghrxspsi.execute-api.us-east-1.amazonaws.com/
titiler-pgstac: https://dg7bp9uptd.execute-api.us-east-1.amazonaws.com/

Everything seems to be working well with the default applications that are shipped with the tipg/titiler-pgstac/stac-fastapi-pgstac packages. Do these changes warrant a major version release? I think we might be due for v8.0 because of the breaking API changes that we are adding in the default titiler-pgstac and stac-fastapi-pgstac runtimes.

I will see about updating the documentation to help users understand the default behavior and point towards examples of how to customize the applications.

@vincentsarago
Copy link
Member

Do these changes warrant a major version release? I think we might be due for v8.0

👍

@hrodmn hrodmn merged commit 7753187 into main Mar 11, 2025
6 checks passed
@hrodmn hrodmn deleted the feat/update-runtime-versions branch March 11, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade default versions of pgstac, titiler-pgstac, stac-fastapi-pgstac, tipg
2 participants