adds a one-way fly_to_command traitlet enabling flyTo from JS#1201
Draft
batpad wants to merge 1 commit into
Draft
adds a one-way fly_to_command traitlet enabling flyTo from JS#1201batpad wants to merge 1 commit into
batpad wants to merge 1 commit into
Conversation
… from JS without a python kernel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if one wants the map to
flyToa location, one has to send a message through Jupyter comms. Thus, it is not possible to update the map view whenlonboardis rendered in static contexts.@kylebarron I know this is something you're not keen on supporting :( and I can see that the design is a lot nicer when going through comms. But it would be really nice to have some way to update the viewport in a frontend-only environment.
This adds a
fly_to_commandtraitlet that is attached to the sharedmodel, so can be set in frontend JS. This implementation should work for me, but am not sure of the naming, etc. Just putting this up as a draft PR and then we can discuss.