[FIX] Error in uploading new file with put #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Mar 11, 2025
|
|
||
| # We check to see if the path is a directory by attempting to list its | ||
| # contexts. If anything is found, it is indeed a directory | ||
| out = await self._ls(path, detail=True) |
There was a problem hiding this comment.
Can you add a comment to this link https://github.com/fsspec/s3fs/blob/01b9c4b838b81375093ae1d78562edf6bdc616ea/s3fs/core.py#L1471-L1492
So that we know where we got it from
There was a problem hiding this comment.
No problem! I just added it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to put a new file to S3, I encounter following error:
This is caused by code here, as fsspec expect all functions run in its event loop.
obstore/obstore/python/obstore/fsspec.py
Lines 479 to 482 in 29ab936
Instead of running
super().infowhen gettingFileNotFoundError, I refer to the method used in s3fs (see here) that use_lsto check if it is directory. If not, raise FileNotFoundError.