Skip to content

feat: Support R2 URLs with jurisdictions#757

Open
Kharacternyk wants to merge 2 commits into
developmentseed:mainfrom
Kharacternyk:main
Open

feat: Support R2 URLs with jurisdictions#757
Kharacternyk wants to merge 2 commits into
developmentseed:mainfrom
Kharacternyk:main

Conversation

@Kharacternyk

Copy link
Copy Markdown

@Kharacternyk

Copy link
Copy Markdown
Author

I don't understand from the GitHub action logs which of my changes are triggering the pre-commit failure

@kylebarron

Copy link
Copy Markdown
Member

Thanks for the PR.

In regards to the pre-commit error, I think the issue is probably that it's not pinned to a specific version of ruff, and that a new version of ruff added that lint.

Separately, the code you're touching in this PR, parse_url is vendored from upstream https://github.com/apache/arrow-rs-object-store. For maintenance reasons, I don't want our copy to diverge from upstream.

So if you could make a PR to upstream object-store, that would be great, and once that is merged, then we can merge this here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants