Skip to content

Update Dockerfile#14

Merged
maxrjones merged 4 commits intomainfrom
upgrade
Feb 28, 2025
Merged

Update Dockerfile#14
maxrjones merged 4 commits intomainfrom
upgrade

Conversation

@maxrjones
Copy link
Member

Updates to use main branches of xarray, zarr, virtualizarr, icechunk, and kerchunk

cc @abarciauskas-bgse @chuckwondo

@abarciauskas-bgse
Copy link
Contributor

abarciauskas-bgse commented Feb 28, 2025

Thanks @maxrjones ! By the way, I have tested using this image on the hub with no issues so far.

@maxrjones
Copy link
Member Author

Thanks @maxrjones ! By the way, I have tested using this image on the hub with no issues so far.

Thanks for the review! I haven't merged this yet because VS Code wasn't working for me. I suspected it might be a breaking code-server release but haven't had time to investigate further yet. Did you use VS Code at all during your test?

@chuckwondo
Copy link
Contributor

Thanks for the review! I haven't merged this yet because VS Code wasn't working for me. I suspected it might be a breaking code-server release but haven't had time to investigate further yet. Did you use VS Code at all during your test?

@maxrjones, perhaps I'm missing something, but it looks like you removed the bits from the Dockerfile that are required for installing the VS Code extension.

Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@maxrjones
Copy link
Member Author

Thanks for the review! I haven't merged this yet because VS Code wasn't working for me. I suspected it might be a breaking code-server release but haven't had time to investigate further yet. Did you use VS Code at all during your test?

@maxrjones, perhaps I'm missing something, but it looks like you removed the bits from the Dockerfile that are required for installing the VS Code extension.

Yes, I removed the VS Code extensions because they were causing build errors and aren't hard to install on the server. VS Code itself in included via code-server in the environment.yml

@abarciauskas-bgse
Copy link
Contributor

@maxrjones I have not used vscode, just jupyterhub

@maxrjones maxrjones merged commit 5a67b6e into main Feb 28, 2025
1 check passed
@maxrjones maxrjones deleted the upgrade branch February 28, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants